-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Bruno Haible on 11/21/2006 6:53 AM: > > Thanks for reporting this. Your patch works, but I'm applying a different > patch, for maintainability reasons. ... > --- 137,150 ---- > dnl to fall back to GNU NLS library. > > if test $gt_api_version -ge 3; then > ! gt_revision_test_code=' > #ifndef __GNU_GETTEXT_SUPPORTED_REVISION > #define __GNU_GETTEXT_SUPPORTED_REVISION(major) ((major) == 0 ? 0 : -1) > #endif > + changequote(,)dnl > typedef int array [2 * (__GNU_GETTEXT_SUPPORTED_REVISION(0) >= 1) - 1]; > ! changequote([,])dnl > ! '
The autoconf manual recommends against changequote when possible, because of a tendency to misuse it (such as forgetting to restore the quotes), although it looks like you managed to get it right here. Furthermore, you used a raw m4 macro changequote; inside of autoconf, you should instead be using the m4sugar wrapper m4_changequote (as it is, how does this even work? m4sugar intentionally disables raw m4 macro names so that they will not be inadvertently expanded). One other thought - would it be worth making this code rely on AC_COMPUTE_INT, rather than open-coding your own checker based on typedef array size, to take advantage of the portability tricks that autoconf has learned over the years about causing a guaranteed compile failure when checking for an integer result? - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFYwh584KuGfSFAYARAhjbAJkBMLdv69TCLPWxN94jiMK8Tb6xeACdFC66 OjiOYt8dhGBAFEBBpecxV5g= =psZ9 -----END PGP SIGNATURE-----
