Bruno Haible <[EMAIL PROTECTED]> wrote:
> Hi Paul,
>
> ok to apply this code simplification?
>
> diff -r -c3 --unidirectional-new-file --exclude=CVS
> gnulib-20060722/m4/stdint.m4 gnulib-20060722-modified/m4/stdint.m4
> *** gnulib-20060722/m4/stdint.m4 2006-07-11 13:54:20.000000000 +0200
> --- gnulib-20060722-modified/m4/stdint.m4 2006-07-23 03:00:45.000000000
> +0200
> ***************
> *** 296,302 ****
> extern $gltype foo;
> extern $gltype1 foo;])],
> [eval gl_cv_type_${gltype}_suffix=\$glsuf])
> ! eval test \"\$gl_cv_type_${gltype}_suffix\" != no && break
> done])
> GLTYPE=`echo $gltype | tr 'abcdefghijklmnopqrstuvwxyz '
> 'ABCDEFGHIJKLMNOPQRSTUVWXYZ_'`
> eval result=\$gl_cv_type_${gltype}_suffix
> --- 321,328 ----
> extern $gltype foo;
> extern $gltype1 foo;])],
> [eval gl_cv_type_${gltype}_suffix=\$glsuf])
> ! eval result=\$gl_cv_type_${gltype}_suffix
> ! test "$result" != no && break
> done])
> GLTYPE=`echo $gltype | tr 'abcdefghijklmnopqrstuvwxyz '
> 'ABCDEFGHIJKLMNOPQRSTUVWXYZ_'`
> eval result=\$gl_cv_type_${gltype}_suffix
Hi Bruno,
That looks like a fine simplification.
I see that there are many other uses of "$result" in that file.
How about using a name that doesn't impinge on the configure.ac
writer's name space? E.g., s/result/gl_result/g in stdint.m4
