Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> Martin Lambers <[EMAIL PROTECTED]> writes: >> >>> Hi! >>> >>> I'd like to propose the following changes to the getpass module. They >>> only affect the W32 part of that module. >>> The first change updates the test for the native W32 API. >>> The second change adds missing includes, thus fixing compilation >>> warnings. >> >> I'm not the official maintainer of getpass, but I think the patch is >> OK and suggest this ChangeLog entry: >> >> 2006-05-26 Martin Lambers <[EMAIL PROTECTED]> >> >> * getpass.c: Updates the test for the native W32 API, and adds >> missing includes, thus fixing compilation warnings. >> >> Of course, in general, it would be better to avoid having a >> win32-specific implementation of the function, but pending work >> towards that goal, we shouldn't stall any improvements to the current >> approach... > > Thanks, Simon. > I agree. Would you please check it in?
Done.
