Simon Josefsson wrote: > Sorry, I didn't read size_max.m4 which seem to be doing some > interesting things.
This means it's time to put some comments. I also had a hard time remembering why <limits.h> and <stdint.h> were used and no others. How about this? > Still, is there a reason the size_max.m4 magic shouldn't be merged > into the stdint module? 1) Is the 'stdint' module tested as much (on as many platforms) as other gnulib modules? gettext doesn't use it so far. coreutils uses it for 3 months only. clisp uses it but is not tested on so many platforms. 2) I use the size_max module inside gettext's libintl, and a full-blown <stdint.h> feels like overkill in this case, when we just need one macro. Bruno *** size_max.h 11 Jul 2005 19:13:35 -0000 1.3 --- size_max.h 27 Apr 2006 18:02:42 -0000 *************** *** 1,5 **** /* size_max.h -- declare SIZE_MAX through system headers ! Copyright (C) 2005 Free Software Foundation, Inc. Written by Simon Josefsson. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* size_max.h -- declare SIZE_MAX through system headers ! Copyright (C) 2005-2006 Free Software Foundation, Inc. Written by Simon Josefsson. This program is free software; you can redistribute it and/or modify *************** *** 19,27 **** --- 19,31 ---- #ifndef GNULIB_SIZE_MAX_H #define GNULIB_SIZE_MAX_H + /* Get SIZE_MAX declaration on systems like Solaris 7/8/9. */ # include <limits.h> + /* Get SIZE_MAX declaration on systems like glibc 2. */ # if HAVE_STDINT_H # include <stdint.h> # endif + /* On systems where these include files don't define it, SIZE_MAX is defined + in config.h. */ #endif /* GNULIB_SIZE_MAX_H */