Paul Eggert wrote on 2006-03-08: > I installed these I-hope-obvious improvements to the unistd module. > I didn't touch the modules Bruno maintains, which might also benefit > from the unistd module.
Thanks. This 'unistd' module is the best invention since <stdbool.h>. I'm applying the same change to all modules borrowed from gettext, except 'setenv' (which is also used for the "relocatable" facility and therefore cannot assume the full gnulib infrastructure). Bruno 2006-04-23 Bruno Haible <[EMAIL PROTECTED]> * copy-file.c: Include <unistd.h> unconditionally. * execute.c: Likewise. * fatal-signal.c: Likewise. * findprog.c: Likewise. * mkdtemp.c: Likewise. * pipe.h: Likewise. * pipe.c: Likewise. * wait-process.h: Likewise. 2006-04-23 Bruno Haible <[EMAIL PROTECTED]> * modules/copy-file: Depend on unistd. * modules/execute: Likewise. * modules/fatal-signal: Likewise. * modules/findprog: Likewise. * modules/mkdtemp : Likewise. * modules/pipe: Likewise. * modules/wait-process: Likewise. *** copy-file.c.bak 2005-09-21 13:08:20.000000000 +0200 --- copy-file.c 2006-04-24 03:49:35.000000000 +0200 *************** *** 1,5 **** /* Copying of files. ! Copyright (C) 2001-2003 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Copying of files. ! Copyright (C) 2001-2003, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 28,37 **** #include <fcntl.h> #include <stddef.h> #include <sys/stat.h> ! ! #ifdef HAVE_UNISTD_H ! # include <unistd.h> ! #endif #if HAVE_UTIME || HAVE_UTIMES # if HAVE_UTIME_H --- 28,34 ---- #include <fcntl.h> #include <stddef.h> #include <sys/stat.h> ! #include <unistd.h> #if HAVE_UTIME || HAVE_UTIMES # if HAVE_UTIME_H *** execute.c.bak 2005-05-14 15:46:40.000000000 +0200 --- execute.c 2006-04-24 03:49:50.000000000 +0200 *************** *** 1,5 **** /* Creation of autonomous subprocesses. ! Copyright (C) 2001-2004 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Creation of autonomous subprocesses. ! Copyright (C) 2001-2004, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 29,38 **** #include <stdbool.h> #include <stdlib.h> #include <signal.h> ! ! #ifdef HAVE_UNISTD_H ! # include <unistd.h> ! #endif #include "error.h" #include "exit.h" --- 29,35 ---- #include <stdbool.h> #include <stdlib.h> #include <signal.h> ! #include <unistd.h> #include "error.h" #include "exit.h" *** fatal-signal.c.bak 2005-09-21 13:08:20.000000000 +0200 --- fatal-signal.c 2006-04-24 03:50:30.000000000 +0200 *************** *** 1,5 **** /* Emergency actions in case of a fatal signal. ! Copyright (C) 2003-2004 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2003. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Emergency actions in case of a fatal signal. ! Copyright (C) 2003-2004, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2003. This program is free software; you can redistribute it and/or modify *************** *** 28,36 **** #include <stdlib.h> #include <signal.h> #include <string.h> ! #if HAVE_UNISTD_H ! # include <unistd.h> ! #endif #include "xalloc.h" --- 28,34 ---- #include <stdlib.h> #include <signal.h> #include <string.h> ! #include <unistd.h> #include "xalloc.h" *** findprog.c.bak 2005-09-21 13:08:20.000000000 +0200 --- findprog.c 2006-04-24 03:50:45.000000000 +0200 *************** *** 1,5 **** /* Locating a program in PATH. ! Copyright (C) 2001-2004 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Locating a program in PATH. ! Copyright (C) 2001-2004, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 27,36 **** #include <stdbool.h> #include <stdlib.h> #include <string.h> ! ! #ifdef HAVE_UNISTD_H ! # include <unistd.h> ! #endif #include "xalloc.h" #include "pathname.h" --- 27,33 ---- #include <stdbool.h> #include <stdlib.h> #include <string.h> ! #include <unistd.h> #include "xalloc.h" #include "pathname.h" *** mkdtemp.c.bak 2006-03-29 14:45:39.000000000 +0200 --- mkdtemp.c 2006-04-24 03:51:12.000000000 +0200 *************** *** 1,4 **** ! /* Copyright (C) 1999, 2001-2003 Free Software Foundation, Inc. This file is part of the GNU C Library. This program is free software; you can redistribute it and/or modify --- 1,4 ---- ! /* Copyright (C) 1999, 2001-2003, 2006 Free Software Foundation, Inc. This file is part of the GNU C Library. This program is free software; you can redistribute it and/or modify *************** *** 45,53 **** # include <inttypes.h> #endif ! #if HAVE_UNISTD_H || _LIBC ! # include <unistd.h> ! #endif #if HAVE_GETTIMEOFDAY || _LIBC # if HAVE_SYS_TIME_H || _LIBC --- 45,51 ---- # include <inttypes.h> #endif ! #include <unistd.h> #if HAVE_GETTIMEOFDAY || _LIBC # if HAVE_SYS_TIME_H || _LIBC *** pipe.c.bak 2005-09-21 13:08:21.000000000 +0200 --- pipe.c 2006-04-24 03:52:22.000000000 +0200 *************** *** 1,5 **** /* Creation of subprocesses, communicating via pipes. ! Copyright (C) 2001-2004 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Creation of subprocesses, communicating via pipes. ! Copyright (C) 2001-2004, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 28,37 **** #include <fcntl.h> #include <stdlib.h> #include <signal.h> ! ! #ifdef HAVE_UNISTD_H ! # include <unistd.h> ! #endif #include "error.h" #include "exit.h" --- 28,34 ---- #include <fcntl.h> #include <stdlib.h> #include <signal.h> ! #include <unistd.h> #include "error.h" #include "exit.h" *** pipe.h.bak 2005-05-14 15:46:42.000000000 +0200 --- pipe.h 2006-04-24 03:52:22.000000000 +0200 *************** *** 1,5 **** /* Creation of subprocesses, communicating via pipes. ! Copyright (C) 2001-2003 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Creation of subprocesses, communicating via pipes. ! Copyright (C) 2001-2003, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 21,29 **** /* Get pid_t. */ #include <stdlib.h> - #ifdef HAVE_UNISTD_H #include <unistd.h> - #endif #include <sys/types.h> #include <stdbool.h> --- 21,27 ---- *** wait-process.h.bak 2005-05-14 15:46:43.000000000 +0200 --- wait-process.h 2006-04-24 03:52:57.000000000 +0200 *************** *** 1,5 **** /* Waiting for a subprocess to finish. ! Copyright (C) 2001-2003 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify --- 1,5 ---- /* Waiting for a subprocess to finish. ! Copyright (C) 2001-2003, 2006 Free Software Foundation, Inc. Written by Bruno Haible <[EMAIL PROTECTED]>, 2001. This program is free software; you can redistribute it and/or modify *************** *** 21,29 **** /* Get pid_t. */ #include <stdlib.h> - #ifdef HAVE_UNISTD_H #include <unistd.h> - #endif #include <sys/types.h> #include <stdbool.h> --- 21,27 ---- *** copy-file.bak 2005-07-06 22:55:57.000000000 +0200 --- copy-file 2006-04-24 03:57:26.000000000 +0200 *************** *** 13,18 **** --- 13,19 ---- binary-io exit gettext-h + unistd configure.ac: gl_COPY_FILE *** execute.bak 2005-07-06 22:55:58.000000000 +0200 --- execute 2006-04-24 03:57:31.000000000 +0200 *************** *** 15,20 **** --- 15,21 ---- gettext-h stdbool strpbrk + unistd configure.ac: gl_EXECUTE *** fatal-signal.bak 2004-09-22 13:58:51.000000000 +0200 --- fatal-signal 2006-04-24 03:57:36.000000000 +0200 *************** *** 11,16 **** --- 11,17 ---- Depends-on: xalloc stdbool + unistd configure.ac: gl_FATAL_SIGNAL *** findprog.bak 2004-09-22 13:58:51.000000000 +0200 --- findprog 2006-04-24 03:57:39.000000000 +0200 *************** *** 11,16 **** --- 11,17 ---- stdbool xalloc pathname + unistd configure.ac: gl_FINDPROG *** mkdtemp.bak 2004-09-22 14:17:25.000000000 +0200 --- mkdtemp 2006-04-24 03:57:48.000000000 +0200 *************** *** 11,16 **** --- 11,17 ---- m4/mkdtemp.m4 Depends-on: + unistd configure.ac: gt_FUNC_MKDTEMP *** pipe.bak 2005-07-06 22:55:59.000000000 +0200 --- pipe 2006-04-24 03:57:52.000000000 +0200 *************** *** 15,20 **** --- 15,21 ---- gettext-h stdbool strpbrk + unistd configure.ac: gl_PIPE *** wait-process.bak 2005-07-06 22:55:59.000000000 +0200 --- wait-process 2006-04-24 03:57:56.000000000 +0200 *************** *** 14,19 **** --- 14,20 ---- xalloc gettext-h stdbool + unistd configure.ac: gl_WAIT_PROCESS