Hi Simon,
* Simon Josefsson wrote on Fri, Mar 03, 2006 at 06:28:35PM CET:
> Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> >
> > Would you install the remaining part of my patch as well, please?
>
> Have you signed copyright papers for gnulib? I can't find them.
This process is not finished yet, unfortunately. Sorry about that
(my fault as well).
> remember asking you about this before,
FWIW, I don't..
> but given the M-C-T and the
> slowness of all spam-checking-enabled mailing lists on gnu.org, you
> probably haven't received. I'm adding you in To: manually.
Thanks.
> Btw, I tested the readline patch, and if no additional library is
> required, it will put '-lreadline -l' into the linker flags. Which
> breaks... maybe you can update it?
Ouch. Darn. Next try below. Thanks for catching this!
Cheers,
Ralf
* readline.m4 (gl_FUNC_READLINE): Rewrite the cached part of the
test to be side-effect free by storing the result in the cache
variable gl_cv_lib_readline, and moving the assignment of
LIBREADLINE and LTLIBREADLINE outside the COMMANDS-TO-SET-IT.
Index: m4/readline.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/readline.m4,v
retrieving revision 1.4
diff -u -r1.4 readline.m4
--- m4/readline.m4 9 Jan 2006 21:42:56 -0000 1.4
+++ m4/readline.m4 3 Mar 2006 17:38:15 -0000
@@ -42,23 +42,20 @@
AC_TRY_LINK([#include <stdio.h>
#include <readline/readline.h>],
[readline((char*)0);],
- gl_cv_lib_readline=yes)
- if test "$gl_cv_lib_readline" = yes; then
- if test -n "$extra_lib"; then
- LIBREADLINE="$LIBREADLINE -l$extra_lib"
- LTLIBREADLINE="$LTLIBREADLINE -l$extra_lib"
- fi
- break
+ [gl_cv_lib_readline=" -l$extra_lib"])
+ if test "$gl_cv_lib_readline" != no; then
+ break
fi
done
LIBS="$am_save_LIBS"
])
- if test "$gl_cv_lib_readline" = yes; then
+ if test "$gl_cv_lib_readline" != no; then
AC_DEFINE(HAVE_READLINE, 1, [Define if you have the readline library.])
- fi
-
- if test "$gl_cv_lib_readline" = yes; then
+ if test "$gl_cv_lib_readline" != " -l"; then
+ LIBREADLINE="$LIBREADLINE$gl_cv_lib_readline"
+ LTLIBREADLINE="$LTLIBREADLINE$gl_cv_lib_readline"
+ fi
AC_MSG_CHECKING([how to link with libreadline])
AC_MSG_RESULT([$LIBREADLINE])
else
_______________________________________________
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
