CCing the commit author. Sorry for using external plugin, but master has two separate unrelated critical regressions (the other one is going via link in *Help* buffer and getting Emacs locked up with 100% CPU and quickly increasing memory usage, which complicates reducing the steps), and since there's a clear commit that introduced the problem I decided to report it as is.
# Steps to reproduce 1. Make sure you're in the Emacs repository and `./build/src/emacs` is the built binary 2. Execute `git clone --depth 1 https://github.com/emacs-evil/evil /tmp/evil` 3. Execute `PATH="$(pwd)/build/src/:$PATH" make -C /tmp/evil emacs` (Emacs with Evil loaded will start) 4. Press `n` to refuse running tests 5. Turn line numbers on by evaluating: (setq-default display-line- numbers 'visual) 6. Press `df` ## Expected Line numbers are still shown ## Actual Line numbers disappear # Additional information The commit that introduced the problem: commit dffdbc1f1fd6569c518e2e3b5e771a54e9e9483f (HEAD) Author: David Ponce <da_...@orange.fr> Date: Thu Aug 22 16:56:11 2024 +0200 Use 'with-work-macro' in 'string-pixel-width' Tweak the implementation of 'string-pixel-width' to run faster and use less memory. Also cater for the case where this function is called in parallel (bug#72689). * lisp/emacs-lisp/subr-x.el (string-pixel-width): Use `with-work-macro'. Prefer `remove-text-properties' to `propertize' to avoid creating a new string on each call. lisp/emacs-lisp/subr-x.el | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) [03.09.2024-17:13:32] constantine@dell-g15 ~/Projects/builds/emacs- git/src/emacs-git ‹node-› ‹› (dffdbc1f1fd*)
