> From: Vincenzo Pupillo <v.pupi...@gmail.com>
> Date: Mon, 02 Sep 2024 15:29:23 +0200
> 
> Ciao, 
> this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver' 
> that 
> allows you to specify an alternative php.ini file to the default (or whatever 
> is specified in 'php-ts-mode-php-config').

Thanks.

> -(defun php-ts-mode-run-php-webserver (&optional port hostname document-root
> -                                                router-script num-of-workers)
> +(defun php-ts-mode-run-php-webserver (&optional port
> +                                                hostname
> +                                                document-root
> +                                                router-script
> +                                                config
> +                                                num-of-workers)
>    "Run PHP built-in web server.

This changes a public API in backward-incompatible way, something we
don't do, because it could break someone's code out there.  (It is
true that php-ts-mode was introduced in Emacs 30, but that version is
already in pretest and will be released soon, so I don't think we can
change this there, either.)

So please find a backward-compatible way of adding this feature,
perhaps add the new CONFIG argument as the last one?

Also, I think this needs a NEWS entry describing the change in
behavior.



Reply via email to