Paul Eggert <egg...@cs.ucla.edu> writes:

> -  parse_gnu_standard_options_only (argc, argv, PROGRAM_NAME, PACKAGE_NAME,
> -                                   Version, true, usage, AUTHORS,
> -                                   (char const *) nullptr);
> +  while (true)

The removal of this function call without removing
#include "long-options.h" causes the following failure when running
'make syntax-check':

    maint.mk: the above files include long-options.h but don't use it
    make: *** [maint.mk:677: sc_prohibit_long_options_without_use] Error 1

I pushed the attached patch to fix it.

Otherwise, the patch was good. Thanks!

Collin

>From c9ae3b553d54a067d880026939de536e6ac39192 Mon Sep 17 00:00:00 2001
Message-ID: <c9ae3b553d54a067d880026939de536e6ac39192.1755226079.git.collin.fu...@gmail.com>
From: Collin Funk <collin.fu...@gmail.com>
Date: Thu, 14 Aug 2025 19:43:52 -0700
Subject: [PATCH] maint: avoid syntax-check failure from previous commit

* src/tsort.c: Don't include long-options.h since the previous commit
removed the call to parse_gnu_standard_options_only. This avoids a
sc_prohibit_long_options_without_use syntax-check failure.
---
 src/tsort.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/tsort.c b/src/tsort.c
index 65050db11..dcbfdc24f 100644
--- a/src/tsort.c
+++ b/src/tsort.c
@@ -27,7 +27,6 @@
 
 #include "system.h"
 #include "assure.h"
-#include "long-options.h"
 #include "fadvise.h"
 #include "readtokens.h"
 #include "stdio--.h"
-- 
2.50.1

Reply via email to