tags 79118 fixed close 79118 stop Collin Funk <collin.fu...@gmail.com> writes:
> Bruno Haible <br...@clisp.org> writes: > >> There are basically two ways to fix this: >> (a) set the appropriate environment variables (instead of setlocale calls), >> (b) add an nstrftime_l and fprintftime_l variant and pass a locale that >> has "C" for the LC_TIME category. >> >> (b) is more hairy, when it comes to the "underlying strftime" delegation in >> gnulib/lib/strftime.c. >> >> Therefore here is a proposed fix according to (a). It fixes the test failures >> on macOS and OpenBSD. It also passes "make syntax-check". > > Thanks for the patch. Interestingly, it passes macOS (cfarm104) but > fails on my OpenBSD VM. > > Let me investigate some more... False alarm. The Gnulib submodule did not have the nstrftime and nstrftime-limited change you recently committed. This means that on OpenBSD 'SUPPORT_NON_GREG_CALENDARS_IN_STRFTIME' was false. I pushed a commit to update that and then pushed your patch, with very minor adjustments to the commit message to make it consistent with Coreutils. Thanks again for the help with this. Collin
