On Mon, Nov 27, 2023 at 07:10:26PM +0000, Pádraig Brady wrote: > On 27/11/2023 16:24, dann frazier wrote: > > * src/tail.c (file_lines): Use fstat() to determine a file's block > > size and dynamically allocate a buffer of that size for traversing > > backwards. > > Thanks for the patch. > Could you describe it a bit more. > What happens if we use smaller reads? > Also what about all the other safe_read() calls in tail.c ?
Yes, this warrants more detail - I'll try to capture that in a comment. Thanks Pádraig! -dann
