On 9/21/21 6:08 AM, Pádraig Brady wrote:
The attached fixes this on my testing on macOS.
Thanks fixing this portability bug that I introduced. I also suggest
changing this:
#ifdef _AIX
- /* select on AIX was seen to give a readable event immediately. */
+ /* select on AIX was seen to give a readable event immediately.
+ Note poll doesn't work for this application on macOS. */
to something like this:
-#ifdef _AIX
- /* select on AIX was seen to give a readable event immediately. */
+ /* Use 'poll' on AIX (where 'select' was seen to give a readable
+ event immediately) or if using inotify (which relies on 'poll'
+ anyway). Otherwise, use 'select' as it's more portable;
+ 'poll' doesn't work for this application on macOS. */
+#if defined _AIX || HAVE_INOTIFY
so that if the inotify code uses 'poll' it uses 'poll' uniformly rather
than sometimes 'poll' and sometimes 'select'.
