On 09/19/2014 08:19 PM, Bernhard Voelker wrote: > On 09/19/2014 06:36 PM, Pádraig Brady wrote: >> Subject: [PATCH] build: fix dependency issues with man page generation >> >> * .gitignore: Remove reference to no longer generated make file. >> * configure.ac: Don't bother generating placeholder make file. >> * man/local.mk: Hardcode the man page deps list for normal builds >> to be compatible with all make implementations and configure options. >> Note in SINGLE_BINARY mode, all man pages will be generated on >> any change to the coreutils binary, but development will generally >> not be done in this mode, so this shouldn't be an issue. > > It is: > > $ make clean > $ make > $ make syntax-check -j > ... > help2man: can't get `--help' info from man/coreutils.td/coreutils > Try `--no-discard-stderr' if option outputs to stderr > prohibit_inttostr_without_use > prohibit_jm_in_m4 > make: *** [man/coreutils.1] Error 127 > make: *** Waiting for unfinished jobs.... > > This only goes away without -j here.
Oops, all that was missing for that case was an entry for coreutils.1 in the static dependency list. Pity we can't use a GNU pattern rule here, and portable suffix rules can't have prerequisites. Note pattern rules seem widely supported, which is tempting. Anyway I added coreutils.1 to the list and pushed. thanks for the review, Pádraig.
