On 04/04/2013 12:06 AM, Bernhard Voelker wrote: > On 04/03/2013 07:43 PM, Pádraig Brady wrote: > >> Subject: [PATCH 1/2] ln: --relative: fix updating of existing symlinks >> >> Don't dereference an existing symlink being replaced. >> I.E. generate the symlink relative to the symlink's containing dir, >> rather than to some arbitrary place it points to. >> >> * src/ln.c (convert_abs_rel): Don't consider the final component >> of the symlink name when canonicalizing, as we to avoid > > s/as we to/as to/ ? > >> dreferencing the final component. > > s/dreferencing/dereferencing/ > > BTW: the commit message should reference this bug: > http://bugs.gnu.org/14116 > >> Subject: [PATCH 2/2] doc: add details on ln --relative symlink resolution >> [...] >> @@ -34,4 +34,15 @@ ln -s dir1/dir2/f existing_link >> ln -srf here existing_link >> test $(readlink existing_link) = 'here' || fail=1 >> >> +# Demonstrate resolved symlinks used to generate relative links >> +# so here,'web/latest' will not be linked to the intermediate 'latest' link. > > s/,/, / > > Apart from the above nits, the 2 patches look good.
Thanks for the review! Pushed.
