On 04/10/10 17:06, Eric Blake wrote: > [please keep the list in the loop] > > On 10/04/2010 08:54 AM, Alain Knaff wrote: >>> One thing that might be possible, however, is to improve df output to >>> adjust column alignment if $COLUMNS >> >> Rather than using $COLUMNS (which is not set by all shells...), it might >> be preferable to do an ioctl(1, TIOCGWINSZ, ...) instead. Indeed, the >> ioctl returns the window size as it is now (even if it has been resized). >> That is what ls does, in any case. > > Yep, for consistency among coreutils, the ioctl approach is definitely best.
... and interestingly enough, the ioctl has the "advantage" of telling us whether the output is indeed a tty or not (it fails with EINVAL if it is not). AFAIU, this is how ls does the trick of finding out whether stdout is a tty or not. In a way, a non-tty could be considered equivalent to an infinetly wide window. > >> >>> is not set (or is set to something >>> large), so as to avoid breaking lines in the case where the output is >>> usable in a long-line context. But this still doesn't help the case >>> that logwatch should have been using -P in the first place. >>> >> >> Agreed. I now also reported the problem to Kirk Bauer from logwatch. > > Glad to hear it. > Regards, Alain
