Eric Blake wrote:
> Cygwin recently improved its <ctype.h> to trigger gcc -Wall warnings on common
> abuses of ctype macros.  As a result, I now see this failure:
>
> truncate.c: In function `main':
> truncate.c:290: warning: subscript has type `char'
> truncate.c:312: warning: subscript has type `char'
>
> On platforms where char is signed, and in single-byte locales where 0xff is a
> space (yes, there are such locales), and where EOF is the traditional value 
> of -
> 1, then isspace((char)0xff) and isspace((unsigned char)0xff) give different
> results.  OK to apply this patch?

Nice.
Your fix looks fine, so go ahead.

Now I wish I'd waited a little longer before releasing 7.4.


_______________________________________________
Bug-coreutils mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-coreutils

Reply via email to