Patrick Schoenfeld wrote:
> On Sun, Mar 22, 2009 at 02:31:32PM +0100, Jim Meyering wrote:
>> Patrick Schoenfeld wrote:
>> > I just remembered that I wrote that patch a while ago.
>> > Its been a while since my copyright assignment got active, so you may
>> > want to commit the patch which I sent a while ago.
>>
>> Thanks for filing the assignment.
>> Did you also address the points I made here?
>>
>> http://www.mail-archive.com/bug-coreutils@gnu.org/msg14650.html
>>
>> I was waiting for an updated patch, but
>> as far as I can see, that never reached the list.
>
> I think I did. I sent it in an own mail as outlined in one of your documents:
>
> http://lists.gnu.org/archive/html/bug-coreutils/2008-11/msg00107.html
Ah, yes. Thanks.
Different thread.
If it's no trouble, would you please rebase and re-post it to the
mailing list as an attachment or using a mail client that doesn't
mangle patches? At least two lines have been split, and that renders
the patch non-applicable. I could join them manually, but...
Your "exit(1);" should be exit (EXIT_FAILURE);
Also, instead of "&", please use "&&" here:
+ if (pedantic & !do_check)
And omit the "= false" here, since that's the default:
+static bool pedantic = false;
Also, in NEWS, you'll have to move your entry to the latest section.
Finally, in this block, please correct the inconsistent indentation:
+ if (pedantic & !do_check)
+ {
+ error (0, 0,
+ _("the --pedantic option is meaningful only when verifying checksums"));
+ usage (EXIT_FAILURE);
+ }
Hmm.. re NEWS, maybe it's not worth it, since adding a new feature,
even one this small, in a bug-fix-only release (upcoming 7.2) is
not the best idea. Since it'll have to go into the to-be-created
section for 7.3.
If rebasing,etc. is a pain, don't worry about it.
I can do the above when I write the tests.
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
