Kamil Dudka wrote: >>>>> +# Skip this test if cp was built without xattr support: >>>>> +grep '^#define USE_XATTR 1' $CONFIG_HEADER > /dev/null || >>>>> + skip_test_ "coreutils built without xattr support" >>>> I'd rather test a binary as it's little less coupled I think: >>>> >>>> cp --preserve=xattr --help >/dev/null 2>&1 || >>>> skip_test_ "coreutils built without xattr support" > Slightly changed to use cp -n instead of cp --help as --help always returns > EXIT_SUCCESS.
Ah because you don't check for !USE_XATTR during option processing, instead deferring to later. I suppose that's OK. So patch looks good! thanks, Pádraig. _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
