Jim Meyering <[EMAIL PROTECTED]> wrote: > Jarod Wilson <[EMAIL PROTECTED]> wrote: >> Hey there, >> >> Trying to reproduce a problem we (Red Hat) are seeing when building coreutils >> 6.12 in our build system[*], and I ran into a slightly different (and 100% >> reproduceable so far) test-suite failure. Log file attached. Build is done on >> a system with a 2.6.18-based kernel (RHEL5.2), building against 2.6.26-ish >> bits in a chrooted environment. >> >> [*] https://bugzilla.redhat.com/show_bug.cgi?id=442352 > > Hi Jarod, > > Thanks for reporting that. > First off, those failures are all in root-only tests.
FYI, I've just pushed this: >From 22d73ed247dbec108439da5eeae5f526390f61d2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Fri, 13 Jun 2008 22:26:15 +0200 Subject: [PATCH] skip (don't fail) root-only tests for common set-up failures Address 2 of 4 failures reported by Jarod Wilson in http://bugzilla.redhat.com/442352. More details here: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13803 * tests/cp/cp-a-selinux: Skip the test if "mkfs -t ext2" fails. * tests/rm/fail-2eperm: Skip the test if "rm" is not accessible. --- THANKS | 1 + tests/cp/cp-a-selinux | 3 ++- tests/rm/fail-2eperm | 3 +-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/THANKS b/THANKS index e1d2089..3e5443b 100644 --- a/THANKS +++ b/THANKS @@ -240,6 +240,7 @@ Jan Moringen [EMAIL PROTECTED] Jan Nieuwenhuizen [EMAIL PROTECTED] Janos Farkas [EMAIL PROTECTED] Jarkko Hietaniemi [EMAIL PROTECTED] +Jarod Wilson [EMAIL PROTECTED] Jean Charles Delepine [EMAIL PROTECTED] Jeff Moore [EMAIL PROTECTED] Jeff Sheinberg [EMAIL PROTECTED] diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux index feb66f9..03d5153 100755 --- a/tests/cp/cp-a-selinux +++ b/tests/cp/cp-a-selinux @@ -33,7 +33,8 @@ cleanup_() { cd /; umount "$cwd/mnt"; } dd if=/dev/zero of=blob bs=8192 count=200 > /dev/null 2>&1 \ || framework_failure mkdir mnt || framework_failure -mkfs -t ext2 -F blob || framework_failure +mkfs -t ext2 -F blob || + skip_test_ "failed to create an ext2 file system" # This context is special: it works even when mcstransd isn't running. ctx=root:object_r:tmp_t:s0 diff --git a/tests/rm/fail-2eperm b/tests/rm/fail-2eperm index 132e22c..6cc66ef 100755 --- a/tests/rm/fail-2eperm +++ b/tests/rm/fail-2eperm @@ -39,8 +39,7 @@ fail=0 rm_version=`setuidgid $NON_ROOT_USERNAME env PATH="$PATH" rm --version|sed -n '1s/.* //p'` case $rm_version in $PACKAGE_VERSION) ;; - *) echo "$0: cannot access just-built rm as user $NON_ROOT_USERNAME" 1>&2 - fail=1 ;; + *) skip_test_ "cannot access just-built rm as user $NON_ROOT_USERNAME";; esac setuidgid $NON_ROOT_USERNAME env PATH="$PATH" rm -rf a 2> out-t && fail=1 -- 1.5.6.rc0.30.g7c3f3 _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
