On Sunday 20 April 2008, Jim Meyering wrote: > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > On Sunday 20 April 2008, Mike Frysinger wrote: > >> On Sunday 20 April 2008, Jim Meyering wrote: > >> > Mike Frysinger <[EMAIL PROTECTED]> wrote: > >> > > has work on merging Andreas' patch just stalled ? that and the big > >> > > nasty i18n patch are about the only thing i carry in Gentoo anymore > >> > > as everything else has been merged ... > >> > > >> > I haven't looked at any xattr-related changes for a long time. > >> > Do you know if there are other variants of that patch (probably), > >> > and if so, how they differ? > >> > >> so we know we're talking about the same thing, i think you're referring > >> to the patch as you cited in an old e-mail and found here: > >> http://www.suse.de/~agruen/coreutils/5.91/ > >> > >> the patch has been updated in opensuse since (i'm attaching the latest > >> one i can find from their coreutils-6.9-43 version). the only thing i > >> have in Gentoo beyond this patch is to add AC_ARG_ENABLE(xattr) support. > > > > hmm, you probably want one that applies nicely ;) > > Thank you. > That's a good first step. > > > here is the Gentoo version which applies to 6.11 > > Hmmm... > I applied the patch and tried to build/compile. No go: > > copy.c: In function 'copy_xattr_filter': > copy.c:191: warning: implicit declaration of function 'attr_copy_action' > copy.c:192: error: 'ATTR_ACTION_SKIP' undeclared (first use in this > function) copy.c:192: error: (Each undeclared identifier is reported only > once copy.c:192: error: for each function it appears in.) > copy.c:194: error: 'ATTR_ACTION_PERMISSIONS' undeclared (first use in > this function) > > So maybe another patch is required?
i researched it and opensuse applies a custom patch to their attr package which creates a new function / enum and coreutils leverages that (which makes for the coreutils code to be much simpler). no idea what Andreas' intentions are here though as i cant seem to find any mention with upstream attr and these changes. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
