-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 4/14/2008 11:13 AM: | | if (xstrtold (x_str + layout.prefix_len, NULL, &x_val, c_strtold) | - && x_val == last) | + && abs_rel_diff (x_val, last) < DBL_EPSILON)
Don't you need to scale the result of abs_rel_diff to be on the same order of magnitude as x_val? DBL_EPSILON represents 1 ulp of 1.0, but 2 ulps of 0.5. It seems like what you are really trying to do here is terminate when the result is within 1 or 2 ulps, not when the result is less than DBL_EPSILON off. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkgDqowACgkQ84KuGfSFAYDEHwCaAlLyED0ugXvRten1/YeFE+Qe wEoAoLPTAisJ7iK06mwipLfsK0my72HK =vSJK -----END PGP SIGNATURE----- _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
