Michael Stone <[EMAIL PROTECTED]> wrote:
> The "simple" dircolors test seems to assume that the controlling shell
> isn't csh. I don't grok the test syntax to make a patch, but this should
> be as simple as running "env SHELL=sh dircolors" instead of just
> "dircolors".
Thanks for reporting that.
Here's the fix:
2006-03-03 Jim Meyering <[EMAIL PROTECTED]>
Don't fail when run from an environment with SHELL not a Bourne
shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
* tests/dircolors/simple: Invoke each non-failing test with -b.
Reported by Michael Stone.
Index: tests/dircolors/simple
===================================================================
RCS file: /fetish/cu/tests/dircolors/simple,v
retrieving revision 1.8
retrieving revision 1.10
diff -u -p -r1.8 -r1.10
--- tests/dircolors/simple 25 Oct 2005 12:00:51 -0000 1.8
+++ tests/dircolors/simple 3 Mar 2006 07:49:39 -0000 1.10
@@ -23,11 +23,14 @@ my @Tests =
['a', {IN => {k => "exec\n"}},
{ERR => "dircolors: k:1: invalid line; missing second token\n"},
{EXIT => 1}],
- ['quote', {IN => "exec 'echo Hello;:'\n"},
+ ['quote', '-b', {IN => "exec 'echo Hello;:'\n"},
{OUT => "LS_COLORS='ex='\\''echo Hello;\\:'\\'':';\n"
. "export LS_COLORS\n"}],
- ['other-wr', {IN => "owt 40;33\n"},
+ ['other-wr', '-b', {IN => "owt 40;33\n"},
{OUT => "LS_COLORS='tw=40;33:';\nexport LS_COLORS\n"}],
+
+ # CAREFUL: always specify the -b option, unless explicitly testing
+ # for csh syntax output.
);
my $save_temps = $ENV{DEBUG};
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
