https://sourceware.org/bugzilla/show_bug.cgi?id=32991

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The binutils-2_44-branch branch has been updated by H.J. Lu
<h...@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=452f5511154ca02095a271cf085e17f536587207

commit 452f5511154ca02095a271cf085e17f536587207
Author: H.J. Lu <hjl.to...@gmail.com>
Date:   Thu May 22 11:29:49 2025 +0800

    x86: Check MODRM for call and jmp in binutils older than 2.45

    When i386 glibc was assembled with commit:

    commit 11c2852449825a5f486f63bc40aabed56b7c04c1 (HEAD)
    Author: Jan Beulich <jbeul...@suse.com>
    Date:   Fri Feb 21 10:24:50 2025 +0100

        x86: widen @got{,pcrel} support to PUSH and APX IMUL

        With us doing the transformation to an immediate operand for MOV and
        various ALU insns, there's little reason to then not support the same
        conversion for the other two insns which have respective immediate
        operand forms. Unfortunately for IMUL (due to the 0F opcode prefix)
        there's no suitable relocation, so the pre-APX forms cannot be marked
        for relaxation in the assembler.

    "pushl main@GOT(%ebx)" in sysdeps/i386/start.S was assembled to

    1c: ff b3 00 00 00 00 push 0x0(%ebx) 1e: R_386_GOT32X main

    Linkers in binutils versions older than 2.45 treated it as jmp and relaxed
    it to

    22c: e9 cf ff ff ff   jmp    200 <main>
    231: 90               nop

    Update elf_i386_convert_load_reloc in binutils versions older than 2.45
    to check MODRM for call and jmp to work with i386 glibc assembled with
    binutils 2.45 or newer.  Do the same in elf_x86_64_convert_load_reloc.

            PR ld/32991
            * elf32-i386.c (elf_i386_convert_load_reloc): Check MODRM for
            call and jmp.
            * elf64-x86-64.c (elf_x86_64_convert_load_reloc): Likewise.

    Signed-off-by: H.J. Lu <hjl.to...@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to