https://sourceware.org/bugzilla/show_bug.cgi?id=31881

--- Comment #8 from Rostislav Krasny <rostiprodev at gmail dot com> ---
Created attachment 15596
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15596&action=edit
patch

Please try this patch. It has changes in the configure.ac file only. The
generated configure script is also stored in Git repository but it is usually
updated by a separate commit, so it's not part of this patch and should be
generated separately.

I tested it with locally built autoconf 2.69 using
"~/local/autoconf-2.69/bin/autoreconf -i" command. Difference between the newly
generated configure script and its version in the master branch was an addition
of the embedded shell code only. Additionally I made yet another temporary
commit (not part of this patch) and tested generation of the bfd/version.h with
"./src-release.sh binutils" command that calls the configure script internally.
Anyone who don't use releases and build directly from Git repo also run this
script, so it should work for them as well.

A few words how I made it. I'm not familiar with the autoconf, so I asked
ChatGPT how can I add an embedded shell code into the generated configure
script. It suggested to use either AC_CONFIG_COMMANDS_PRE or AC_CONFIG_COMMANDS
and it forgot about AC_CONFIG_COMMANDS_POST. I decided to use
AC_CONFIG_COMMANDS_PRE, i.e. the bfd/version.h file is generated by the
configure script at the very beginning. Hope this decision was right.

I use current format of the BFD_VERSION_DATE for compatibility but I suggest to
change it in a future to something more precise. The change should be done in
the "--date=format:%Y%m%d" part of the git log command, according to
strftime(3)

I also changed the first sentence of the comment in the now generated the
bfd/version.h, so please check my English too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to