https://sourceware.org/bugzilla/show_bug.cgi?id=25677
Nick Clifton <nickc at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2020-03-25
Status|UNCONFIRMED |ASSIGNED
CC| |nickc at redhat dot com
--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
Hi Stephen,
Thanks very much for creating this patch. The changes themselves
look fine, although there is one issue - a linker testsuite
regression:
FAIL: extract symbols
This is from the ld/testsuite/ld-scripts section of the tests and
happened for me when testing with a toolchain configured for
"pdp11-dec-aout". An examination of the test and the log file
suggests that the problem is that file containing the extracted
symbol also contains some data. I am not sure why this would be
happening, but please could you investigate.
Another important issue is that in order to be able to accept the
patch we will need an FSF Copyright assignment from you. You can
start this process by filling out the form here and then emailing
it off:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=doc/Copyright/request-assign.changes;hb=HEAD
The patch will definitely need to be extended to include some
documentation in the ld/ld.texi file. It would also help if you
added a sentence or two to the ld/NEWS file mentioning the new
feature.
Ideally we would also like to see a new linker test to check the
behaviour of the new code. I am not sure how easy this will be
to write, but please do try.
Cheers
Nick
--
You are receiving this mail because:
You are on the CC list for the bug.
