https://sourceware.org/bugzilla/show_bug.cgi?id=21545
Bug ID: 21545
Summary: relro_test.sh can be simplified, eliminating
dependency on dc
Product: binutils
Version: 2.27
Status: UNCONFIRMED
Severity: minor
Priority: P2
Component: gold
Assignee: ccoutant at gmail dot com
Reporter: sourceware at jonathancottrill dot net
CC: ian at airs dot com
Target Milestone: ---
Created attachment 10082
--> https://sourceware.org/bugzilla/attachment.cgi?id=10082&action=edit
[PATCH] Simplify gold relro_test; eliminate dc dependency
gold/testsuite/relro_test.sh does some unnecessarily complicated manipulation
of hex values, along with some arithmetic using dc. dc doesn't necessarily
exist on all systems trying to build and check binutils, and isn't needed
because the shell script can do the hex arithmetic, itself, using the $(())
construct.
For example:
RELRO_END=$((RELRO_START + RELRO_LEN))
...works fine with hex values prefixed with 0x stored in RELRO_START and
RELRO_LEN.
The end result is simpler and easier to follow. (I also simplified a couple of
grep/awk commands.) Please see the attached patch (against current master).
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils
