On ubuntu (jaunty), the build of the gold plugin fails with:
../../src/gold/reduced_debug_output.h: In member function 'void
gold::Output_reduced_debug_abbrev_section::failed(std::string)':
../../src/gold/reduced_debug_output.h:67: error: format not a string literal and
no format arguments
../../src/gold/reduced_debug_output.h: In member function 'void
gold::Output_reduced_debug_info_section::failed(std::string)':
../../src/gold/reduced_debug_output.h:113: error: format not a string literal
and no format arguments
Presumably -Wformat is on by default in ubuntu's gcc. The following patch
fixes it:
Index: gold/reduced_debug_output.h
===================================================================
--- gold.orig/reduced_debug_output.h 2009-02-04 10:18:27.000000000 +0100
+++ gold/reduced_debug_output.h 2009-02-04 10:27:50.000000000 +0100
@@ -64,7 +64,7 @@
void
failed(std::string reason)
{
- gold_warning(reason.c_str());
+ gold_warning("%s", reason.c_str());
failed_ = true;
}
@@ -110,7 +110,7 @@
void
failed(std::string reason)
{
- gold_warning(reason.c_str());
+ gold_warning("%s", reason.c_str());
this->failed_ = true;
}
--
Summary: gold build failure "format not a string literal and no
format arguments"
Product: binutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: gold
AssignedTo: ian at airs dot com
ReportedBy: baldrick at free dot fr
CC: bug-binutils at gnu dot org
http://sourceware.org/bugzilla/show_bug.cgi?id=9812
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils
