> > On 11/11/25 4:15 PM, [email protected] wrote: > From: Andrew Oates <[email protected]> > The usage of selfb, before, etc in this block do not match the > conditions where they are declared above. Therefore, on a system (for > example) that has none of HAVE_GETRUSAGE, HAVE_GETTIMEOFDAY, nor > HAVE_TIMES defined, this will fail to compile. Likewise, a system with > HAVE_GETRUSAGE but neither of the other two will also fail. > Can you give me an example of such a system?
The custom kernel I'm building and getting bash to compile on :D That system has HAVE_GETTIMEOFDAY, but not the other two. For what it's worth, I think it would be entirely defensible for bash to say: we don't support such systems. However the code currently _attempts_ to support them, but doesn't do so correctly --- this patch fixes that, though I have only tested it on a system that has HAVE_GETTIMEOFDAY, and one with all three, not the other permutations. So I would advocate for either fixing this, or tearing out the support for these knobs altogether and make them required. That would make me personally sad, as it's very cool that bash can compile and run for my custom kernel, but again, it's certainly defensible. Thoughts? [sorry about the email threading issues, trying to get my subscription to bug-bag@ sorted out]
