Follow-up Comment #2, sr #110886 (project autoconf):
Hi Zack,
Thanks for the prompt feedback.
Another issue I've found is that the mishandling of 'dnl' comments; they are
often added into the argument itself, breaking for example this AC_TRY_RUN at
configure time:
@@ -2200,9 +2188,8 @@ if test "$wxUSE_ZLIB" != "no" ; then
dnl has anything more ancient (1.1.3 was released in July 1998)
dnl anyhow
AC_CACHE_CHECK([for zlib.h >= 1.1.4], ac_cv_header_zlib_h,
- [AC_TRY_RUN(
- dnl zlib.h defines ZLIB_VERSION="x.y.z"
- [
+ [AC_RUN_IFELSE([AC_LANG_SOURCE([[dnl zlib.h defines
ZLIB_VERSION="x.y.z"
+
#include <zlib.h>
#include <stdio.h>
#include <stdlib.h>
@@ -2218,12 +2205,7 @@ if test "$wxUSE_ZLIB" != "no" ; then
ZLIB_VERSION[4] >= '4')) ? "yes" : "no");
return 0;
}
- ],
- ac_cv_header_zlib_h=`cat conftestval`,
- ac_cv_header_zlib_h=no,
- dnl cross-compiling: don't have an answer, try later
- unset ac_cv_header_zlib_h
- )]
+ ]])],[ac_cv_header_zlib_h=`cat
conftestval`],[ac_cv_header_zlib_h=no],[dnl cross-compiling: don't have an
answer])]
)
dnl If the test above did not come up with a value (e.g. cross
dnl compiling) then this should give a definitive answer
Which results in the config.log to:
conftest.c:43:1: error: unknown type name 'dnl'
43 | dnl zlib.h defines ZLIB_VERSION="x.y.z"
| ^~~
conftest.c:43:9: error: expected '=', ',', ';', 'asm' or '__attribute__'
before '.' token
43 | dnl zlib.h defines ZLIB_VERSION="x.y.z"
| ^
I understand redesigning to fix the root of these problems may take a long
time to fix (or never happen). I may take a peek myself if I find the time.
Cheers,
Maxim
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/support/?110886>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
