On 01/09/2011 02:19 AM, Ralf Wildenhues wrote: > [ replacing automake-patches with autoconf-patches ] > > tying up another loose end: > > * Ralf Wildenhues wrote on Wed, Dec 22, 2010 at 07:22:24AM CET: >> Hmpf. Nowadays AM_CYGWIN just expands to AC_CYGWIN, which causes >> $CYGWIN to be set. The latter is probably a bad idea for other reasons >> (Cygwin AFAIK uses the variable for other purposes), but at least one >> macro in Autoconf's fortran.m4 still seems to make use of $CYGWIN. It >> should at least also be fixed to use $host_os instead. > > The patch below should address that. I have no idea whether this code > is still relevant on Cygwin, but I'm assuming that it is. I haven't > actually tested it there, but I'm running the testsuite on GNU/Linux > right now to ensure there are no undesired side effects. OK to push > when that passes?
Yes, please push. $CYGWIN should never be modified during a configure script on Cygwin, so checking $host_os is indeed better. > Avoid reference to $CYGWIN in Fortran macros. > > * lib/autoconf/fortran.m4 (_AC_FC_LIBRARY_LDFLAGS): Require > AC_CANONICAL_HOST. Replace test for $CYGWIN with $host_s test. > I'll fire up a full testsuite run on cygwin later, and in the unlikely event of a regression, I'll report back; it just that it takes several hours to run a full testsuite. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
