On 07/06/2010 05:09 PM, Bruno Haible wrote: >> My current recommendation on this, since it's a warning only, is to >> either ignore it, or use -Wno-syntax to silence it for now. WDYT? > > There is no reason for the warning, because the version string does not > contain characters that would be dangerous in comments, inside single-quotes, > inside double-quotes, or in here documents (namely newline, single-quote, > double-quote, backslash, dollar). Therefore the warning should not be > present.
Hmm, for AS_BOX, I changed things to avoid AS_LITERAL_IF altogether, and just hard-coded the check for $, \, and ` (the three things that are not safe for an unquoted here-doc). I could probably do the same for AC_INIT on the version string, but I'm out of time this morning for attempting that. Maybe tonight... (And I finally figured out a way to get my normal email client to work remotely, instead of suffering through the web-mail interface that was breaking threading). -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
