On 06/19/2010 09:21 AM, Ralf Wildenhues wrote:
> Seems we can't rely on dot returning an error status; this is the only
> failure on AIX 5.1 with /bin/sh and current git plus one unrelated
> patch:
> 
> + ./configure
> stderr:
> ./configure[1550]: syntax error at line 2 : `fi' unexpected
> stdout:
> configure: loading site script /tmp/tests/testsuite.dir/209/bad.site
> ../../autoconf/tests/base.at:419: exit code was 0, expected 1

Thanks for the report.  I'm thinking that it might be best to just add
something like:

AC_CHECK([. ./bad.site && exit 77], [ignore], [ignore], [ignore])

prior to the configure test, to skip this test on AIX; can you confirm
whether that would be sufficient?  Exiting on sourcing failure is
preferable, but I don't see any alternative, and at least the user still
gets a message on stderr; besides, you would normally expect a
config.site to be well-formed so that failure to detect a bad
config.site is an unlikely case to begin with.

-- 
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to