_I_ don't see a reason considering that boost.cmake allows both Static
and Shared in the same build so there really isn't a choice. Also,
there does not really seem to be any consensus on Windows how to name
libraries. So I say go for it until someone has a problem with it.
--
Mike Jackson <www.bluequartz.net>
On Dec 16, 2009, at 5:34 PM, Troy D. Straszheim wrote:
Michael Jackson <mike.jack...@bluequartz.net> writes:
In the FindBoost.cmake file there is a line like:
# Setting some more suffixes for the library
SET (Boost_LIB_PREFIX "")
if ( WIN32 AND Boost_USE_STATIC_LIBS )
SET (Boost_LIB_PREFIX "lib")
endif()
Which means the Boost.Cmake project really needs to mimic this,
which it
tried to do, but just missed like you said, probably just over
looked it.
In that same BoostCore.cmake file there is:
if (THIS_LIB_IS_STATIC)
add_library(${VARIANT_LIBNAME} STATIC ${THIS_LIB_SOURCES})
# On Windows, we need static and shared libraries to have
# different names, so we follow the Boost.Build version 2 style
# and prepend "lib" to the name.
if(WIN32 AND NOT (CYGWIN OR MINGW))
set_target_properties(${VARIANT_LIBNAME}
PROPERTIES
PREFIX "${LIBPREFIX}" <===== Probably just change this?
)
endif()
.....
Change that to:
set_target_properties(${VARIANT_LIBNAME}
PROPERTIES
PREFIX "lib"
)
Thoughts?
Looks good to me. I'll bet "LIBPREFIX" was set someplace else
(BoostConfig.cmake?) at one point and was accidentially deleted during
one cleanup or other. I don't see a reason to make this
user-configurable (do you?)?
-t
_______________________________________________
Boost-cmake mailing list
Boost-cmake@lists.boost.org
http://lists.boost.org/mailman/listinfo.cgi/boost-cmake
_______________________________________________
Boost-cmake mailing list
Boost-cmake@lists.boost.org
http://lists.boost.org/mailman/listinfo.cgi/boost-cmake
