Perfect, thanks Mason. LGTM1 then. On Thu, Jul 10, 2025 at 8:42 PM Mason Freed <mas...@chromium.org> wrote:
> > On Thu, Jul 10, 2025 at 3:08 PM Rick Byers <rby...@chromium.org> wrote: > >> Interoperability and Compatibility >>> >>> Use counters are relatively high: >>> https://chromestatus.com/metrics/feature/timeline/popularity/4272 >>> However, analysis from Mozilla shows that perhaps the impact is not as >>> large as the use counters would suggest: >>> https://github.com/whatwg/html/issues/7867#issuecomment-2595987424 >>> Firefox has now shipped the complete removal of this behavior for two >>> milestones with no reported issues. >>> >> >> I tend to agree this should be low risk. In particular I assume the >> "severity of breakage" is very low here (worst case some text is just a bit >> bigger) and "ease of mitigation" is very high, right? The accessibility and >> interoperability gains make this worth trying and accepting a bit of compat >> pain for, but I am a little worried we may find eg. some enterprise / LOB >> app which has an unacceptable UI regression. So I'm supportive as long as >> we've got a plan to flag off if needed. >> > > Thanks. I think that's right - the change is just different margins and > font sizes (by a little) and the fix is to add explicit `font-size` and > `margin` CSS rules to get the sizes the site wants. > > The plan is certainly to have a kill switch in case problems are > encountered. I'm leaning heavily on Mozilla's work here - they did some > http archive research (showing only minor impact) and they've shipped it > and heard crickets. > > >> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> Yes >>> >>> >>> https://wpt.fyi/results/html/rendering/non-replaced-elements/sections-and-headings >>> >> >> Nice. Do we match Firefox at 100% passing when we ship this? >> > > Yep > <https://chromium-review.googlesource.com/c/chromium/src/+/6725454/2/third_party/blink/web_tests/external/wpt/html/rendering/non-replaced-elements/sections-and-headings/headings-styles-no-h1-in-section.tentative-expected.txt> > ! > > >> Finch feature nameNone >>> >> >> This needs a kill switch flag, right? Just in case of an emergency web >> compat issue? >> > > Yeah, I'm still landing the flag, but I'll update the chromestatus when > it's ready. Tentative name (not yet landed) is > `SpecialRulesForNestedH1Elements`. > > Thanks, > Mason > > > >>> >>> Non-finch justificationNone >>> >>> Rollout planWill ship enabled for all users >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://issues.chromium.org/issues/394111284 >>> >>> Estimated milestones >>> Shipping on desktop 140 >>> DevTrial on desktop 136 >>> Shipping on Android 140 >>> DevTrial on Android 136 >>> Shipping on WebView 140 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/6192419898654720?gate=4740512881573888 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDga_GXVFf6fjoNQ7Y3w5xDDT5U0m75fGYEgnCEV4B2i%3Dg%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDga_GXVFf6fjoNQ7Y3w5xDDT5U0m75fGYEgnCEV4B2i%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8wQZzw6UrRPcpKRN7gav8LWr8hdwC6wL43MgKMN_FQ4Q%40mail.gmail.com.