Thank you all for your approvals.

@Chris Harrelson<mailto:chris...@chromium.org> - have updated the signal.

@Philip Jägenstedt<mailto:foo...@chromium.org> - After investigating the test, 
I found that it has been failing since last month after a new assert was added 
in this 
merge<https://chromium-review.googlesource.com/c/chromium/src/+/6650946>. I 
have created a bug to update the test and assigned it to myself.
calc in font-variation settings does not match expectation in WPT test 
[430464509] - Chromium<https://issues.chromium.org/issues/430464509>
Shall I go ahead and ship this?

Thank you,
Sejal


________________________________
From: blink-dev@chromium.org <blink-dev@chromium.org> on behalf of Daniel 
Bratell <bratel...@gmail.com>
Sent: Wednesday, July 9, 2025 8:57 PM
To: Chris Harrelson <chris...@chromium.org>; Philip Jägenstedt 
<foo...@chromium.org>
Cc: Chromestatus <ad...@cr-status.appspotmail.com>; blink-dev@chromium.org 
<blink-dev@chromium.org>; Ragvesh Sharma's Organization (FTE) 
<ragvesh_org_...@microsoft.com>
Subject: [EXTERNAL] Re: [blink-dev] Intent to Ship: Support 
font-variation-settings descriptor in @font-face rule


LGTM3

/Daniel

On 2025-07-09 17:23, Chris Harrelson wrote:
LGTM2, with one note below.

On Wed, Jul 9, 2025 at 8:07 AM Philip Jägenstedt 
<foo...@chromium.org<mailto:foo...@chromium.org>> wrote:
LGTM1, I'm happy to see this ship too.

I took a look at all tests with font-variation-settings in 
the<https://wpt.fyi/results/?label=master&label=experimental&aligned&q=font-variation-settings>
 path, and see that 
calc-in-font-variation-settings.html<https://wpt.fyi/results/css/css-fonts/calc-in-font-variation-settings.html>
 is still failing, but the same in all browsers. Can you take a look at this 
test before shipping this? If the test is wrong per spec, just updating it 
would be great.

On Tue, Jul 8, 2025 at 7:50 AM Chromestatus 
<ad...@cr-status.appspotmail.com<mailto:ad...@cr-status.appspotmail.com>> wrote:

WebKit: Positive (https://github.com/WebKit/standards-positions/issues/525)

Positive is incorrect given that link, the correct status is "no signal".
--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8bYp1HXGV1ZjnLKyoOY7d8c-8gbgZ_Dpg6Fi5KSnotZg%40mail.gmail.com<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8bYp1HXGV1ZjnLKyoOY7d8c-8gbgZ_Dpg6Fi5KSnotZg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9bc5468b-1f54-4e59-9ea1-7495c28ffb5c%40gmail.com<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9bc5468b-1f54-4e59-9ea1-7495c28ffb5c%40gmail.com?utm_medium=email&utm_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/KUXP153MB1400E6DEFC6D0FF96CC0114DD449A%40KUXP153MB1400.APCP153.PROD.OUTLOOK.COM.

Reply via email to