LGTM3

(Not all chromestatus reviews have completed so pay attention to additional feedback there; though I don't expect any or I would not have sent the LGTM)

/Daniel

On 2025-05-22 15:19, Yoav Weiss (@Shopify) wrote:
LGTM2

This is an exciting feature that will enable the adoption of more aggressive speculation rules in scenarios that are too risky to deploy today!

On Thu, May 22, 2025 at 2:10 PM Mike Taylor <miketa...@chromium.org> wrote:

    On 5/22/25 1:16 AM, Domenic Denicola wrote:

    On Wed, May 21, 2025 at 9:48 PM Mike Taylor
    <miketa...@chromium.org> wrote:

        On 5/20/25 10:07 PM, Domenic Denicola wrote:

        (Feature-collaborator hat on, API owners hat off.)

        Thanks for sending this! A few minor corrections here, that
        it'd be good to make to the ChromeStatus entry.

        On Wed, May 21, 2025 at 10:42 AM Chromestatus
        <ad...@cr-status.appspotmail.com> wrote:


                    Contact emails

            steven...@microsoft.com


                    Explainer

            
https://github.com/WICG/nav-speculation/blob/main/clear-site-data-integration.md



                    Specification

            https://chromium-review.googlesource.com/c/chromium/src/+/6456388


        This is not a specification, but instead a Chromium CL. You
        can link to
        
https://wicg.github.io/nav-speculation/prefetch.html#clear-site-data-patches
        and
        
https://wicg.github.io/nav-speculation/prerendering.html#interaction-with-clear-site-data
        for the specification.

        Thanks for linking these, Domenic.

        Has there been any discussion with WebAppSec about future
        integration with the clear-site-data spec? I tried to find an
        issue or agenda topic, but didn't come up with anything.


    There has not, so thank you for reminding us to do that. I've
    posted this issue
    <https://github.com/w3c/webappsec-clear-site-data/issues/89>.

    Since clear-site-data is unmaintained (it's actually listed in
    the W3C dashboard of specs which could benefit from more
    maintenance
    <https://github.com/w3c/spec-maintenance/wiki/Spec-list>), I
    don't have high hopes for this issue getting much of a response.

    Furthermore, since prefetch and prerender are still in incubation
    in general, I think it's reasonable to keep using the
    monkey-patch model for them until upstreaming happens. (We hope
    to work on upstreaming for prefetch later this year
    <http://github.com/whatwg/html/issues/11123>.) That is, it would
    feel weird to add these values directly to the clear-site-data
    spec and have it call out to a still-incubating spec.

    But you're overall totally right to call us out that the correct
    thing to do when monkey-patching is to alert the upstream
    community, so thank you for that.

    Thanks! I agree that monkey-patching here is reasonable, so long
    as there's some engagement with a WG that might adopt it down the
    road.

    LGTM1



                    Summary

            We propose adding two new values to the Clear-Site-Data
            header to help developers target clearing the prerender
            and prefetch cache: “prefetchCache” and “prerenderCache”.



                    Blink component

            Blink>Loader>Preload
            
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ELoader%3EPreload%22>



                    TAG review

            https://github.com/w3ctag/design-reviews/issues/1091


                    TAG review status

            Pending


                    Risks



                    Interoperability and Compatibility

            None



            /Gecko/: Positive
            (https://github.com/mozilla/standards-positions/issues/1214)


            /WebKit/: No signal
            (https://github.com/WebKit/standards-positions/issues/488)

            /Web developers/: No signals


        We have positive signals from engineers at Shopify at
        
https://github.com/WICG/nav-speculation/issues/357#issuecomment-2766677746
        , as well as a separate engineer (/using/ Shopify) at
        https://github.com/WICG/nav-speculation/issues/352 .



            /Other signals/:


                    WebView application risks

            Does this intent deprecate or change behavior of
            existing APIs, such that it has potentially high risk
            for Android WebView-based applications?

            None



                    Debuggability

            None



                    Will this feature be supported on all six Blink
                    platforms (Windows, Mac, Linux, ChromeOS,
                    Android, and Android WebView)?

            No


        It's good to explain the reason here. The reason is that
        speculation rules prefetch and prerender is not yet
        supported on Android WebView.



                    Is this feature fully tested by
                    web-platform-tests
                    
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

            No

            Adding tests.


        I think you already added the tests in
        https://chromium-review.googlesource.com/c/chromium/src/+/6456388 ,
        and they're now visible at
        
https://wpt.fyi/results/speculation-rules?label=master&label=experimental&aligned&q=clear-site-data
        
<https://wpt.fyi/results/speculation-rules?label=master&label=experimental&aligned&q=clear-site-data>
        .



                    Flag name on about://flags

            ClearSiteDataPrefetchPrerenderCache


        This is actually the Finch feature name. We don't have any
        flag name on about://flags.



                    Finch feature name

            None


                    Non-finch justification

            None


                    Rollout plan

            Will ship enabled for all users


                    Requires code in //chrome?

            False


                    Tracking bug

            https://issues.chromium.org/issues/398149359


                    Estimated milestones

            No milestones specified


        I think we're targeting 138.



                    Anticipated spec changes

            Open questions about a feature may be a source of future
            web compat or interop issues. Please list open issues
            (e.g. links to known github issues in the project for
            the feature specification) whose resolution may
            introduce web compat/interop risk (e.g., changing to
            naming or structure of the API in a
            non-backward-compatible way).

            None


                    Link to entry on the Chrome Platform Status

            
https://chromestatus.com/feature/4755745652080640?gate=5143125462614016



                    Links to previous Intent discussions

            Intent to Prototype:
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/680bb74f.170a0220.15e62e.053b.GAE%40google.com



            This intent message was generated by Chrome Platform
            Status <https://chromestatus.com>.
-- You received this message because you are subscribed to
            the Google Groups "blink-dev" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to
            blink-dev+unsubscr...@chromium.org.
            To view this discussion visit
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/682d2f79.170a0220.2aa17e.1064.GAE%40google.com
            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/682d2f79.170a0220.2aa17e.1064.GAE%40google.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the
        Google Groups "blink-dev" group.
        To unsubscribe from this group and stop receiving emails
        from it, send an email to blink-dev+unsubscr...@chromium.org.
        To view this discussion visit
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_oZxMAzyCKF3%3DY7Yt9s%3DS5C4C8CJ5pPM%3D2NXGGyj3dfQ%40mail.gmail.com
        
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_oZxMAzyCKF3%3DY7Yt9s%3DS5C4C8CJ5pPM%3D2NXGGyj3dfQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4551eaf1-81e5-42c6-90f2-2ed63068491c%40chromium.org
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4551eaf1-81e5-42c6-90f2-2ed63068491c%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2BaNLMVFucVr54K-Ynn3g8eZS%2B6SiauDF28Lpvf1tEjPw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2BaNLMVFucVr54K-Ynn3g8eZS%2B6SiauDF28Lpvf1tEjPw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c37f65a2-003b-47a1-8323-e63e3d70b94f%40gmail.com.

Reply via email to