LGTM3 Sorry this fell off our radar (was due to re-using the existing chromestatus entry so looked fully approved in tooling already).
On Wed, Apr 30, 2025 at 7:09 AM Mike Taylor <miketa...@chromium.org> wrote: > LGTM2 > On 4/28/25 5:43 PM, Chris Harrelson wrote: > > LGTM1. Please make sure to ping the standards positions with the updated > shape as well. > > On Mon, Apr 28, 2025 at 12:08 PM Stephen McGruer <smcgr...@chromium.org> > wrote: > >> > Conveniently, the various review bits that we now require are not >> requested at >> https://chromestatus.com/feature/5165040614768640?gate=5060726757785600 >> (maybe because they didn't exist?). So you could request those now. For API >> OWNERs - just repinging this thread should be fine. >> >> The various review bits are now approved, for the updated API shape + >> design! >> >> So requesting a re-review from API OWNERS, thanks. Let me know if it >> needs to be 3x LGTM or just 1x :). >> On Wednesday, March 12, 2025 at 6:40:08 PM UTC-4 Mike Taylor wrote: >> >>> On 3/10/25 10:12 AM, Stephen McGruer wrote: >>> >>> > It may change shape before finally shipping (in particular, I'm musing >>> over whether true/false is sufficient information and whether we could give >>> developers more specific enum reasons without leaking user privacy) - I'll >>> come back to the thread for approval if we want to ship anything >>> substantially different. >>> >>> We have now decided that indeed we want to do things a little >>> differently, and are proposing (spec issue >>> <https://github.com/w3c/secure-payment-confirmation/issues/284>, spec PR >>> <https://github.com/w3c/secure-payment-confirmation/pull/285>, new >>> design doc >>> <https://docs.google.com/document/d/1ZgNRqyJyB36ItqUr6vtlJ19rd7fqpS7Vo0w_GSMz0DA/edit?tab=t.0#heading=h.4f9946en7wca>) >>> an enum of output states instead of a boolean true/false. This hopefully >>> also addresses previous feedback >>> <https://github.com/w3c/secure-payment-confirmation/issues/81#issuecomment-1527105768> >>> from >>> Mike West on being more specific about when the API should return >>> true/false. >>> >>> What's the right process here for re-requesting review? We should >>> probably *at least* go back through privacy review as adding an enum of >>> more-specific reasons that a feature isn't available definitely has a >>> fingerprinting risk! Is it possible to 'reset' stages in chromestatus? >>> >>> Conveniently, the various review bits that we now require are not >>> requested at >>> https://chromestatus.com/feature/5165040614768640?gate=5060726757785600 >>> (maybe because they didn't exist?). So you could request those now. For API >>> OWNERs - just repinging this thread should be fine. >>> >>> >>> Thanks! >>> >>> On Thursday, January 23, 2025 at 12:58:46 PM UTC-5 Stephen McGruer wrote: >>> >>>> > I'm assuming no other facts on the ground (signals, TAG feedback, >>>> etc) have changed in the meantime? If so, then this plan sounds fine to me. >>>> >>>> Yes, sorry, no other changes at this time from the wider W3C community. >>>> Partners continue to ask for an easier way to feature-detect SPC, and >>>> finally we're getting around to delivering! >>>> >>>> On Thursday, January 23, 2025 at 11:20:18 AM UTC-5 Chris Harrelson >>>> wrote: >>>> >>>>> On Thu, Jan 23, 2025 at 7:36 AM Stephen McGruer <smcgr...@chromium.org> >>>>> wrote: >>>>> >>>>>> Hey folks, >>>>>> >>>>>> Can't quite I'm coming back to this thread near on 2 years later 🤣, >>>>>> but wanted to fyi that this didn't actually ship in the end. However, we >>>>>> are finally coming back to it now (honest - I have CLs out >>>>>> <https://chromium-review.googlesource.com/c/chromium/src/+/6194313>! >>>>>> :D), and expect to ship this sometime in the coming months. It may change >>>>>> shape before finally shipping (in particular, I'm musing over whether >>>>>> true/false is sufficient information and whether we could give developers >>>>>> more specific enum reasons without leaking user privacy) - I'll come back >>>>>> to the thread for approval if we want to ship anything substantially >>>>>> different. >>>>>> >>>>> >>>>> I'm assuming no other facts on the ground (signals, TAG feedback, etc) >>>>> have changed in the meantime? If so, then this plan sounds fine to me. >>>>> >>>>> >>>>>> >>>>>> Thanks, >>>>>> Stephen >>>>>> >>>>>> On Friday, April 28, 2023 at 11:30:27 AM UTC-4 Chris Harrelson wrote: >>>>>> >>>>>>> LGTM3 >>>>>>> >>>>>>> On Fri, Apr 28, 2023 at 12:22 AM Mike West <mk...@chromium.org> >>>>>>> wrote: >>>>>>> >>>>>>>> LGTM2. >>>>>>>> >>>>>>>> I think it would be valuable to extend the spec PR with more >>>>>>>> description of the considerations around when the feature is available >>>>>>>> (see >>>>>>>> discussion at >>>>>>>> https://github.com/w3c/secure-payment-confirmation/issues/81#issuecomment-1527105768), >>>>>>>> but I don't think that will meaningfully change the shape of the API >>>>>>>> or its >>>>>>>> meaning in Chromium's implementation. >>>>>>>> >>>>>>>> -mike >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Apr 27, 2023 at 4:33 PM Nick Burris <nbur...@chromium.org> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Le jeudi 20 avril 2023 à 12 h 58 min 34 s UTC-4, Nick Burris a >>>>>>>>> écrit : >>>>>>>>> >>>>>>>>> Contact emailsnbur...@chromium.org, smcgr...@chromium.org, >>>>>>>>> i...@chromium.org >>>>>>>>> >>>>>>>>> Specificationhttps://github.com/w3c/secure- >>>>>>>>> payment-confirmation/pull/233 >>>>>>>>> >>>>>>>>> Design docshttps://docs.google.com/document/d/10zFazJRJMwNLKmH- >>>>>>>>> GJRFMDs4rONIO5kF8TvdFydmGek/edit >>>>>>>>> >>>>>>>>> Summary >>>>>>>>> >>>>>>>>> This is a Javascript API to provide an easier way to check if the >>>>>>>>> Secure Payment Confirmation[1] feature is available. Currently, the >>>>>>>>> only >>>>>>>>> way to determine SPC’s availability is to create a PaymentRequest >>>>>>>>> with the >>>>>>>>> required parameters[2], which is clunky and difficult in the case >>>>>>>>> where a >>>>>>>>> developer wants to check for SPC before starting to process a >>>>>>>>> payment. [1] >>>>>>>>> https://www.w3.org/TR/secure-payment-confirmation/ [2] >>>>>>>>> https://github.com/w3c/secure-payment-confirmation/issues/ >>>>>>>>> 81#issuecomment-868473461 >>>>>>>>> >>>>>>>>> >>>>>>>>> Blink componentBlink>Payments >>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPayments> >>>>>>>>> >>>>>>>>> TAG reviewNone >>>>>>>>> >>>>>>>>> TAG review statusNot applicable >>>>>>>>> >>>>>>>>> Risks >>>>>>>>> Interoperability and Compatibility*Gecko*: N/A ( >>>>>>>>> https://github.com/mozilla/standards-positions/issues/570) >>>>>>>>> >>>>>>>>> *WebKit*: N/A (https://github.com/WebKit/ >>>>>>>>> standards-positions/issues/30) >>>>>>>>> >>>>>>>>> *Web developers*: Positive (https://github.com/w3c/ >>>>>>>>> secure-payment-confirmation/issues/81) We've received feedback >>>>>>>>> from web developers that an easier mechanism to check for SPC >>>>>>>>> availability >>>>>>>>> would be useful. >>>>>>>>> >>>>>>>>> *Other signals*: >>>>>>>>> >>>>>>>>> WebView application risks >>>>>>>>> >>>>>>>>> Does this intent deprecate or change behavior of existing APIs, >>>>>>>>> such that it has potentially high risk for Android WebView-based >>>>>>>>> applications? >>>>>>>>> >>>>>>>>> None >>>>>>>>> >>>>>>>>> >>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?Yes >>>>>>>>> >>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>> ? >>>>>>>>> To be added to secure-payment-confirmation suite >>>>>>>>> <https://wpt.fyi/results/secure-payment-confirmation?label=experimental&label=master&aligned> >>>>>>>>> >>>>>>>>> Flag name--enable-blink-features=SecurePaymentConfirmationAvail >>>>>>>>> ableAPI >>>>>>>>> >>>>>>>>> Requires code in //chrome?True >>>>>>>>> >>>>>>>>> Estimated milestonesShipping on desktop114Shipping on Android114 >>>>>>>>> >>>>>>>>> >>>>>>>>> FYI, we missed the 114 branch so we're pushing this back to M115. >>>>>>>>> >>>>>>>>> >>>>>>>>> Anticipated spec changes >>>>>>>>> >>>>>>>>> https://github.com/w3c/secure-payment-confirmation/pull/233 >>>>>>>>> >>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>> https://chromestatus.com/feature/5165040614768640 >>>>>>>>> >>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>> <https://chromestatus.com/>. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "blink-dev" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8910ee13-a798-4388-a2c3-659e1b18fa14n%40chromium.org >>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8910ee13-a798-4388-a2c3-659e1b18fa14n%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "blink-dev" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>> >>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfHDCGw%2BS%2BAeroZ9jvPVkLj%3DckzPTMkgdCh79BTHVCUDw%40mail.gmail.com >>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfHDCGw%2BS%2BAeroZ9jvPVkLj%3DckzPTMkgdCh79BTHVCUDw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>> . >>>>>>>> >>>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> >>>>> To view this discussion visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4b142740-5d3b-4d87-a23f-3a5b8ca7b5dcn%40chromium.org >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4b142740-5d3b-4d87-a23f-3a5b8ca7b5dcn%40chromium.org?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/7322526e-afcf-4022-b335-e22661364ebfn%40chromium.org >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/7322526e-afcf-4022-b335-e22661364ebfn%40chromium.org?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9a3c5828-abb4-4657-b3f1-7285b624a553n%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9a3c5828-abb4-4657-b3f1-7285b624a553n%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b020c564-cabf-4d52-8c31-d93248deee8f%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b020c564-cabf-4d52-8c31-d93248deee8f%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_GBkOMEJ-FE_FO3tfpAxDdOEj5Yv_Sxw7q47SxVL7YAg%40mail.gmail.com.
