LGTM3

/Daniel

On 2025-04-02 17:11, Alex Russell wrote:
LGTM2

On Tuesday, April 1, 2025 at 11:55:16 PM UTC-7 Guido Urdaneta wrote:

    On Wed, Apr 2, 2025 at 4:33 AM Vladimir Levin
    <vmp...@chromium.org> wrote:

        LGTM1

                Interoperability risk is relatively low. The main risk
                is that other browsers do not implement the feature.
                However, since the feature is a small addition to an
                existing spec and it has consensus across browsers, it
                is possible that it will be implemented. There is no
                compatibility risk as the feature is strictly additive
                and orthogonal to existing features.

        I assume that this can be feature detected (as presence or
        absence of the information) and in non-supporting browsers,
        the app would fall back to whatever the current behavior is.
        Is that a reasonable approach for developers?


    This is correct.



                /Gecko/: Positive
                (https://github.com/w3c/mediacapture-screen-share/pull/315
                <https://github.com/w3c/mediacapture-screen-share/pull/315>)
                Since this is a minor addition to an existing spec, no
                official position was requested as it would have been
                closed without response. The provided link points to
                the PR where Firefox's representative was supportive.

                /WebKit/: Positive
                (https://github.com/w3c/mediacapture-screen-share/pull/315
                <https://github.com/w3c/mediacapture-screen-share/pull/315>)
                Since this is a minor addition to an existing spec, no
                official position was requested as it would have been
                closed without response. The provided link points to
                the PR where Safari's representative approved.


        I would typically err on the side of filing a position request
        regardless of the size of the feature. I don't believe it's
        common that these would be closed without a response. However,
        in this specific case I agree that the approval and comments
        on the pull request seem to be sufficient evidence of support.


    Will request official positions next time.
    Last year we had this case:
    https://github.com/WebKit/standards-positions/issues/334
    <https://github.com/WebKit/standards-positions/issues/334>

        Thanks,
        Vlad

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f52e5637-6e42-4181-9067-e01d3990c173n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f52e5637-6e42-4181-9067-e01d3990c173n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ae4a9ba2-416f-46e7-94ab-ebcada68992e%40gmail.com.

Reply via email to