LGTM2
On 2/25/25 2:19 AM, Daniel Bratell wrote:
LGTM1
Would be nice if something could be done about the remaining parts,
but creating interoperability is valuable on its own.
/Daniel
On 2025-02-19 17:54, Daniil Sakhapov wrote:
I don't know why we don't support image-resolution property, it seems
like noone does.
It would make most sense to remove those tests for image-resolution,
and move the tests to a separate file for grid-template-rows.
среда, 19 февраля 2025 г. в 13:39:36 UTC+1, Yoav Weiss:
Thanks for catching us up here!
On Wednesday, February 19, 2025 at 11:29:12 AM UTC+1 Daniil
Sakhapov wrote:
The first 3 tests are for image-resolution property, which we
(and others?) don't support.
Why not?
The last 3 tests are for grid-template-rows, which requires
also display: grid, and some elements inside the grid, but
the person who added the test didn't change HTML, so the test
is wrongly expects a value, but in always will be 'none'.
Can we fix the tests?
вторник, 18 февраля 2025 г. в 18:28:55 UTC+1, Mike Taylor:
On 2/18/25 8:28 AM, Chromestatus wrote:
Contact emails sakha...@chromium.org
Explainer None
Specification
https://www.w3.org/TR/css-values-4/#sign-funcs
<https://www.w3.org/TR/css-values-4/#sign-funcs>
Summary
The sign-related functions abs() and sign() compute
various functions related to the sign of their argument.
The abs(A) function contains one calculation A, and
returns the absolute value of A, as the same type as the
input: if A’s numeric value is positive or 0⁺, just A
again; otherwise -1 * A. The sign(A) function contains
one calculation A, and returns -1 if A’s numeric value
is negative, +1 if A’s numeric value is positive, 0⁺ if
A’s numeric value is 0⁺, and 0⁻ if A’s numeric value is
0⁻. The return type is a <number>, made consistent with
the input calculation’s type.
Blink component Blink>CSS
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ECSS%22>
TAG review None
TAG review status Not applicable
Risks
Interoperability and Compatibility
None
/Gecko/: Shipped/Shipping
/WebKit/: Shipped/Shipping
/Web developers/: Strongly positive
https://issues.chromium.org/issues/40253181#comment9
<https://issues.chromium.org/issues/40253181#comment9>
https://issues.chromium.org/issues/40253181#comment10
<https://issues.chromium.org/issues/40253181#comment10>
/Other signals/:
WebView application risks
Does this intent deprecate or change behavior of
existing APIs, such that it has potentially high risk
for Android WebView-based applications?
None
Debuggability
None
Will this feature be supported on all six Blink
platforms (Windows, Mac, Linux, ChromeOS, Android, and
Android WebView)? Yes
Is this feature fully tested by web-platform-tests
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?
Yes
https://wpt.fyi/css/css-values/signs-abs-computed.html
<https://wpt.fyi/css/css-values/signs-abs-computed.html>
I see there's 6 tests near the bottom that all browsers
are failing. What's up with that?
Flag name on about://flags CSSSignRelatedFunctions
Finch feature name None
Non-finch justification None
Requires code in //chrome? False
Tracking bug https://issues.chromium.org/issues/40253181
<https://issues.chromium.org/issues/40253181>
Estimated milestones Shipping on desktop 135 Shipping on
Android 135 Shipping on WebView 135
Anticipated spec changes
Open questions about a feature may be a source of future
web compat or interop issues. Please list open issues
(e.g. links to known github issues in the project for
the feature specification) whose resolution may
introduce web compat/interop risk (e.g., changing to
naming or structure of the API in a
non-backward-compatible way).
None
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5091423843778560?gate=5117360513744896
<https://chromestatus.com/feature/5091423843778560?gate=5117360513744896>
This intent message was generated by Chrome Platform
Status <https://chromestatus.com>.
--
You received this message because you are subscribed to
the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails
from it, send an email to
blink-dev+unsubscr...@chromium.org
<mailto:blink-dev+unsubscr...@chromium.org>.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67b48aed.2b0a0220.393e4c.08de.GAE%40google.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67b48aed.2b0a0220.393e4c.08de.GAE%40google.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/91d654e3-dbb2-4f5b-a13c-f1ee1fa444c5n%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/91d654e3-dbb2-4f5b-a13c-f1ee1fa444c5n%40chromium.org?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fda7a548-9813-44a1-b052-bb4267b41286%40chromium.org.
