LGTM3 On Wednesday, January 22, 2025 at 3:30:55 PM UTC+1 Vladimir Levin wrote:
> LGTM2 > > I think this is an extremely useful attribute, so I don't doubt that web > developers signal is strongly positive, but is there any evidence you can > point to? > > Thanks, > Vlad > > On Wed, Jan 22, 2025 at 6:39 AM Mike Taylor <miketa...@chromium.org> > wrote: > >> LGTM1 >> On 1/15/25 5:57 PM, Mason Freed wrote: >> >> Contact emails mas...@chromium.org >> >> Explainer None >> >> Specification https://html.spec.whatwg.org/#attr-dialog-closedby >> >> Summary >> >> One of the nice features of the Popover API is its light dismiss >> behavior. This chromestatus is about bringing that same capability to >> `<dialog>`. A new `closedby` attribute controls behavior: `<dialog >> closedby=none>` - no user-triggered closing of dialogs at all. `<dialog >> closedby=closerequest>` - user pressing ESC (or other close trigger) closes >> the dialog `<dialog closedby=any>` - user clicking outside the dialog, or >> pressing ESC, closes the dialog. Akin to `popover=auto` behavior. >> >> >> Blink component Blink>DOM >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EDOM%22> >> >> Search tags dialog <https://chromestatus.com/features#tags:dialog>, light >> dismiss <https://chromestatus.com/features#tags:light%20dismiss> >> >> TAG review None >> >> TAG review status Not applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> None >> >> >> *Gecko*: No signal ( >> https://github.com/mozilla/standards-positions/issues/998) >> >> *WebKit*: No signal ( >> https://github.com/WebKit/standards-positions/issues/329) >> >> The WebKit position is trending positive, based on >> https://github.com/WebKit/standards-positions/issues/329#issuecomment-2604702351. >> >> >> >> >> *Web developers*: Strongly positive >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> None >> >> >> Debuggability >> >> None >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> >> https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element?label=master&label=experimental&aligned&q=closedby >> >> Given that the PR landed in HTML, can we remove .tentative from the tests? >> >> >> >> Flag name on about://flags HTMLDialogLightDismiss >> >> Finch feature name HTMLDialogLightDismiss >> >> Requires code in //chrome? False >> >> Tracking bug https://crbug.com/376516550 >> >> Estimated milestones >> Shipping on desktop 134 >> DevTrial on desktop 133 >> Shipping on Android 134 >> DevTrial on Android 133 >> Shipping on WebView 134 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5097714453577728?gate=5165153493188608 >> >> Links to previous Intent discussions Intent to Prototype: >> https://groups.google.com/a/chromium.org/g/blink-dev/c/eDXEmWB7Xo8/m/3ZsbU8AwBgAJ >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDh3596VtU3%3DcdGU%2BMoPCrU2APkgn2ji8qPzXKwqqVJJBQ%40mail.gmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDh3596VtU3%3DcdGU%2BMoPCrU2APkgn2ji8qPzXKwqqVJJBQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> > To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/13397ff4-c252-4eab-996a-e240d803d66f%40chromium.org >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/13397ff4-c252-4eab-996a-e240d803d66f%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f6f6cd53-0d8d-4912-81c4-ca802a8128dfn%40chromium.org.
