LGTM1 On Wed, Dec 18, 2024 at 5:11 PM Daseul Lee <ds...@google.com> wrote:
> > > On Wed, Dec 18, 2024 at 10:46 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> Thanks for working on this!! :) >> >> On Wednesday, December 18, 2024 at 4:33:10 AM UTC+1 ds...@google.com >> wrote: >> >> Contact emails >> >> ds...@chromium.org, memm...@chromium.org >> >> Explainer >> >> https://github.com/whatwg/fs/blob/main/proposals/FileSystemObserver.md >> >> Specification >> >> https://github.com/whatwg/fs/pull/165 >> >> >> What's blocking the PR from landing? >> > There is one open question about whether FileSystemChangeRecord should be > an interface or a dictionary, which we plan on shipping with a dictionary > first so that it's easy to support the switch to an interface, if it > happens. > Other than that, it's just generally been taking a while to get > replies/approval. :) > I see the PR got approved. Thanks for following through on this! :) > >> >> >> Design docs >> >> [Design Doc] File System Observer >> <https://docs.google.com/document/d/1d6YoPvk0rdNBQaZcoFP-V5u4CBjgahvmnVsZpbn0Gmo/edit?usp=sharing> >> >> Summary >> >> The FileSystemObserver interface notifies websites of changes to the file >> system. Sites observe changes to files and directories to which the user >> has previously granted permission, in the user's local device (as specified >> in WICG/file-system-access) or in the Bucket File System (as specified in >> whatwg/fs), and are notified of basic change info, such as the change type. >> >> >> Blink component >> >> Blink>Storage>FileSystem >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EStorage%3EFileSystem%22> >> >> TAG review >> >> https://github.com/w3ctag/design-reviews/issues/868 >> >> TAG review status >> >> Issues addressed >> >> Origin Trial Name >> >> FileSystemObserver interface >> >> Chromium Trial Name >> >> FileSystemObserver >> >> Origin Trial documentation link >> >> https://github.com/whatwg/fs/blob/main/proposals/FileSystemObserver.md >> >> WebFeature UseCounter name >> >> kV8FileSystemObserver_Constructor >> >> RisksInteroperability and Compatibility >> >> Gecko: Positive (https://github.com/mozilla/ >> standards-positions/issues/942) >> >> WebKit: No signal (https://github.com/WebKit/ >> standards-positions/issues/291) >> >> Web developers: Strongly positive (https://github.com/WICG/file- >> system-access/issues/72) >> >> Use case from Origin Trial: https://insiders.vscode.dev >> >> Security >> >> Sites are only able to observe a file or a directory which the user has >> granted permission to. >> >> WebView application risks >> >> Not enabled on WebView >> >> >> Debuggability >> >> New WebIDL interface and attributes are available on DevTools console. >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? >> >> No. Desktop only. >> >> This feature relies on FileSystemHandle object from whatwg/fs, which was >> only available on desktop until M132 when it was shipped on Android. Future >> work remains to enable FileSystemObserver API on Android. >> >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? >> >> Yes >> >> https://wpt.fyi/results/fs/FileSystemObserver.https. >> tentative.any.html?label=experimental&label=master >> >> >> Flag name on about://flags >> >> file-system-observer >> >> Finch feature name >> >> FileSystemObserver >> >> Requires code in //chrome? >> >> False >> >> Tracking bug >> >> https://issues.chromium.org/40105284 >> >> Launch bug >> >> https://launch.corp.google.com/launch/4261040 >> >> Estimated milestones >> >> Shipping on desktop >> >> 133 >> >> Origin trial desktop first >> >> 129 >> >> Origin trial desktop last >> >> 134 >> >> >> Anticipated spec changes >> >> There is an open question about whether `FileSystemChangeRecord` should >> be an interface or a dictionary. >> >> Link to entry on the Chrome Platform Status >> >> https://chromestatus.com/feature/4622243656630272?gate=5657135488172032 >> >> Links to previous Intent discussions >> >> Intent to Prototype: https://groups.google.com/a/ >> chromium.org/d/msgid/blink-dev/CAGnvaEXNQ0OUo61DXeuhzARPyOu_ >> E6vA6VsD6%2BBwVDGW_0BQJw%40mail.gmail.com >> >> Intent to Experiment: https://groups.google.com/a/ >> chromium.org/d/msgid/blink-dev/CAPhTbOjWuKV_MpRhG3bZ3Oj% >> 3Dy5eQCvdR6iGBDrM%2BqTGpwgiWGQ%40mail.gmail.com >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2B0PYch5TTGpYc9pjsdHSkcSkVWU%3D1yBzwOXkLgY-q94A%40mail.gmail.com.
