On Friday, December 20, 2024 at 3:46:04 PM UTC+1 Mike Taylor wrote:

Thanks David for flagging.

Can we hold off on shipping until the issue settles?
On 12/19/24 10:44 AM, David Baron wrote:

I'm a little concerned that the discussion in https://github.com/w3c/
csswg-drafts/issues/10834 may lead to some changes; I think it's at least 
worth monitoring that issue over the next few weeks to see what happens 
there.

There’s also some ongoing discussion 
in 
https://github.com/WebKit/standards-positions/issues/432#issuecomment-2553396257
 
about text-box.


-David

On Thu, Dec 19, 2024 at 4:38 AM Koji Ishii <ko...@chromium.org> wrote:

Thank you for checking this:
 

The spec you link has a red note saying:


"This is an early draft of a proposal, and might change significantly as 
design critiques and use cases are registered and various details and 
interactions with other properties are worked out. Do not ship (yet)."


Does that only apply to the properties you listed?


That's a left over, one removed as Mike pointed out but one still left. 
I'll check with the editor.

Coincidentally, Safari shipped these properties on Dec 11 
<https://github.com/WebKit/standards-positions/issues/432#issuecomment-2537122575>
.

2024年12月19日(木) 1:00 Daniel Bratell <bratel...@gmail.com>:

Ok, so let's go!

LGTM3

/Daniel
On 2024-12-18 16:55, Mike Taylor wrote:

I had the same question (as it was noted in the WebKit position), but found 
https://github.com/w3c/csswg-drafts/commit/3b15a485b2f9dfaa8e9ad3958ec262
5d7857f719. I assume this I2S means we agree. :)
On 12/18/24 10:39 AM, Daniel Bratell wrote:

The spec you link has a red note saying:

"This is an early draft of a proposal, and might change significantly as 
design critiques and use cases are registered and various details and 
interactions with other properties are worked out. Do not ship (yet)."

Does that only apply to the properties you listed?

/Daniel
On 2024-12-18 16:34, Yoav Weiss (@Shopify) wrote:

LGTM2

On Wednesday, December 18, 2024 at 4:29:51 PM UTC+1 Mike Taylor wrote:

LGTM1
On 12/11/24 11:49 AM, Koji Ishii wrote:

Contact emails lin...@chromium.org, ko...@chromium.org

Explainer None

Specification https://drafts.csswg.org/css-inline-3/#text-edges

Summary 

To achieve optical balance of text content, the text-box-trim and 
text-box-edge properties, along with the text-box shorthand property, make 
finer control of vertical alignment of text possible. The text-box-trim 
property specifies the sides to trim, above or below, and the text-box-edge 
property specifies how the edge should be trimmed. These properties allow 
developers to control vertical spacing precisely by using the font metrics. 
Note that the `ideographic` and `ideographic-ink`, two values for the 
text-box-edge property for CJK, are deferred to future releases due to open 
issues currently under discussion.


Blink component Blink>Layout>Inline 
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ELayout%3EInline%22>

TAG review https://github.com/w3ctag/design-reviews/issues/1021 
TAG review status Pending

Risks 


Interoperability and Compatibility 


*Gecko*: No signal (https://github.com/mozilla/standards-positions/issues/
1105)

*WebKit*: In development (https://github.com/WebKit/
standards-positions/issues/432) Available under a flag, original bug 
https://bugs.webkit.org/show_bug.cgi?id=245599

*Web developers*: Positive (https://medium.com/microsoft-
design/leading-trim-the-future-of-digital-typesetting-d082d84b202) 
https://github.com/markdalgleish/figma-leading-trim

*Other signals*:

WebView application risks 

Does this intent deprecate or change behavior of existing APIs, such that 
it has potentially high risk for Android WebView-based applications?

No.


Debuggability 

Will this feature be supported on all six Blink platforms (Windows, Mac, 
Linux, ChromeOS, Android, and Android WebView)? Yes

Is this feature fully tested by web-platform-tests 
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
? Yes 

https://wpt.fyi/results/css/css-inline/text-box-trim?
label=experimental&label=master&aligned


Flag name on about://flags text-box-trim

Finch feature name CSSTextBoxTrim

Requires code in //chrome? False

Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1411581

Estimated milestones Shipping on desktop 133 DevTrial on desktop 128 Shipping 
on Android 133 DevTrial on Android 128 Shipping on WebView 133 

Anticipated spec changes 

Open questions about a feature may be a source of future web compat or 
interop issues. Please list open issues (e.g. links to known github issues 
in the project for the feature specification) whose resolution may 
introduce web compat/interop risk (e.g., changing to naming or structure of 
the API in a non-backward-compatible way).
None.

Link to entry on the Chrome Platform Status https://chromestatus.com/
feature/5174589850648576?gate=5185376392577024

Links to previous Intent discussions Intent to Prototype: https://groups.
google.com/a/chromium.org/g/blink-dev/c/Sn8TF5KHrRU


This intent message was generated by Chrome Platform Status 
<https://chromestatus.com/>.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAHe_1d%2BK92_9kSvObCgk-ShO6iWyvXyvvzR3%
2BT9Bh4Wp0u0z1A%40mail.gmail.com 
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHe_1d%2BK92_9kSvObCgk-ShO6iWyvXyvvzR3%2BT9Bh4Wp0u0z1A%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/95c3fb72-c1e2-4b59-9e92-
bfb48df74aadn%40chromium.org 
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/95c3fb72-c1e2-4b59-9e92-bfb48df74aadn%40chromium.org?utm_medium=email&utm_source=footer>
.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAHe_1dKK%2Bn2Hcv%
3Dh5cxBpFY21PjbsCzT1UTcuWtyHN-JnuLYmw%40mail.gmail.com 
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHe_1dKK%2Bn2Hcv%3Dh5cxBpFY21PjbsCzT1UTcuWtyHN-JnuLYmw%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a10c6d47-300c-4863-aad7-41bd0ba86bf4n%40chromium.org.

Reply via email to