On Fri, Nov 29, 2024 at 5:02 AM Rune Lillesveen <futh...@chromium.org> wrote:
> > On Wed, Nov 27, 2024 at 4:49 PM Rick Byers <rby...@chromium.org> wrote: > >> LGTM3 >> >> Is anyone looking into why the tests >> <https://wpt.fyi/results/css/css-conditional/container-queries/scroll-state> >> have harness errors on non-chromium browsers? Is that a bug in the test >> failing to fail properly? >> > > The issue is that I use assert_implements() for > container-type:scroll-state in the setup() function as it makes no sense to > continue without it, and to make sure there are no false positives in > subtests. But consulting the wpt documentation it seems I need to repeat > that in every single subtest instead. It would be convenient to have some > pre-condition check in setup() that causes every subtest to fail instead of > causing a harness error. > Interesting, thanks for looking into it. Feel free to file a WPT bug for improving the infra (/cc @Panos Astithas <pastit...@chromium.org>). >> Rick >> >> On Wed, Nov 27, 2024 at 10:48 AM Chris Harrelson <chris...@chromium.org> >> wrote: >> >>> LGTM2 >>> >>> On Sun, Nov 24, 2024 at 7:22 AM Mike Taylor <miketa...@chromium.org> >>> wrote: >>> >>>> LGTM1 >>>> On 11/21/24 4:12 AM, Rune Lillesveen wrote: >>>> >>>> On Wed, Nov 13, 2024 at 10:38 AM Rune Lillesveen <futh...@chromium.org> >>>> wrote: >>>> >>>>> Four issues are opened against the spec: >>>>> >>>>> https://github.com/w3c/csswg-drafts/issues/11181 >>>>> https://github.com/w3c/csswg-drafts/issues/11182 >>>>> https://github.com/w3c/csswg-drafts/issues/11183 >>>>> https://github.com/w3c/csswg-drafts/issues/11127 >>>>> >>>>> The one that's blocking shipping is the potential renaming from >>>>> 'overflowing' to 'scrollable': >>>>> https://github.com/w3c/csswg-drafts/issues/11182 >>>>> >>>> >>>> This has now been resolved. >>>> >>>> Two of the others are convenience keyword additions, and the last one >>>>> is a non-behavioral editorial change to the spec. >>>>> >>>> >>>> 11181 and 11183 have been scheduled for async resolution. >>>> >>>> -- >>>> Rune Lillesveen >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeSqvXZcGbJwczY_anrcTuN2_2Sd19ALKjtLq7am-P7wzw%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeSqvXZcGbJwczY_anrcTuN2_2Sd19ALKjtLq7am-P7wzw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a02ee4a6-8ec9-44aa-ae1a-c3cdc54db67a%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a02ee4a6-8ec9-44aa-ae1a-c3cdc54db67a%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_k7nC22L-2YrNU6FB9grft%3D%2BtBJrx08PNoniNZVGrugQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_k7nC22L-2YrNU6FB9grft%3D%2BtBJrx08PNoniNZVGrugQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> > > -- > Rune Lillesveen > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_c77Sw4iJpCjNpdXtppmbrdJ4_j89GhuxoLPvZv9k%3DjA%40mail.gmail.com.
