LGTM2 On Wed, Nov 27, 2024 at 7:42 AM Rick Byers <rby...@chromium.org> wrote:
> LGTM1 to ship in M133. > > It's nice to see the explainer and design improved based on TAG feedback, > thank you for that! > > Rick > > On Tue, Nov 26, 2024 at 10:41 AM David Awogbemila <awogbem...@chromium.org> > wrote: > >> >> >> On Tue, Nov 26, 2024 at 10:35 AM David Awogbemila < >> awogbem...@chromium.org> wrote: >> >>> Contact emailsawogbem...@google.com >>> >>> Explainerhttps://github.com/DavMila/explainer-animation.progress >>> >>> Specification >>> https://drafts.csswg.org/web-animations-2/#the-overall-progress-of-an-animation >>> >>> Summary >>> >>> This feature adds an "overallProgress" property to the JavaScript class >>> Animation[1]. The goal of this property is to provide authors a convenient >>> and consistent representation of how far along an animation has advanced >>> across its iterations and regardless of the nature of its timeline[2]. [1] >>> https://developer.mozilla.org/en-US/docs/Web/API/Animation [2] >>> https://developer.mozilla.org/en-US/docs/Web/API/AnimationTimeline >>> >>> >>> Blink componentBlink>Animation >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EAnimation> >>> >>> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/994 >>> >>> TAG review statusIssues addressed >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> None >>> >>> >>> *Gecko*: No signal ( >>> https://github.com/mozilla/standards-positions/issues/1073) >>> >>> *WebKit*: No signal ( >>> https://github.com/WebKit/standards-positions/issues/398) >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> Like other fields in the Animation class, overallProgress can be >>> inspected with DevTools. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)?Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> >>> https://wpt.fyi/results/web-animations/interfaces/Animation/overallProgress.tentative.html >>> https://wpt.fyi/results/web-animations/interfaces/Animation/scroll-timeline-overallProgress.tentative.html >>> >>> Note that those test results might be showing as failing for a brief >>> period because the feature was renamed from "progress" to "overallProgress" >>> recently, and while the WPTs have immediately picked up this change, the >>> version of Chrome against which they are run has yet to be similarly >>> updated. However, you can see from the history >>> <https://wpt.fyi/results/web-animations/interfaces/Animation?run_id=5103325284663296> >>> that past runs of the tests were passing: progress.tentative.html >>> <https://wpt.fyi/results/web-animations/interfaces/Animation/progress.tentative.html?run_id=5103325284663296> >>> & >>> scroll-timeline-progress.tentative.html >>> <https://wpt.fyi/results/web-animations/interfaces/Animation/scroll-timeline-progress.tentative.html?run_id=5103325284663296> >>> . >>> >>> Flag name on about://flagsAnimationProgressAPI >>> >>> Finch feature nameNone >>> >>> Non-finch justificationNone >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://crbug.com/40914396 >>> >>> Sample links >>> https://codepen.io/bramus/pen/BaXwmyZ >>> https://codepen.io/awogbemila/pen/oNKpXWy >>> https://davmila.github.io/demo-animation.progress/tda/index.html >>> https://davmila.github.io/demo-animation.progress/sda/index.html >>> >>> Estimated milestones >>> >>> No milestones specified >>> >> We expect to ship this in M133. I've updated the Chromestatus entry. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA6pwF6P_GBZWKr_Ve2HqS%2BkXxfpEbHwY78o-s7ke9kSF3DbFw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA6pwF6P_GBZWKr_Ve2HqS%2BkXxfpEbHwY78o-s7ke9kSF3DbFw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-i_KDPix9JnPuZhFszZ1J-Mn8LD0z2Ae1TWWU696LPrg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-i_KDPix9JnPuZhFszZ1J-Mn8LD0z2Ae1TWWU696LPrg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-f5S0gwh4ZgqD6G44bu31dX%3Dt7%3DXnRMq%2BM4FQCnYQ3_g%40mail.gmail.com.
