LGTM3 On Wed, Oct 23, 2024 at 8:35 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote:
> LGTM2 > > On Wednesday, October 23, 2024 at 8:10:45 AM UTC-7 Vladimir Levin wrote: > > LGTM1. I think this is a straightforward improvement to the feature set. > > On Fri, Oct 11, 2024 at 3:34 PM Rune Lillesveen <futh...@chromium.org> > wrote: > > On Fri, Oct 11, 2024 at 8:30 PM Alex Russell <slightly...@chromium.org> > wrote: > > Hey Rune, > > It's surprising that there aren't any developer signals given that we're > going first and there are no signals from other vendors and that there's no > explainer with a compelling code example that shows how this solves an > important problem (although I think I can imagine what it is). Can we do a > bit more to shore up the "*we're solving an important problem well*" > > collateral? > > > Is this a comment on the original shipping of anchor positioning? > > Should I copy the signals and TAG review entries from > https://chromestatus.com/feature/5124922471874560 ? > > This is a minor change to allow anchor-size() in margins and insets based > on a CSSWG resolution after the realization that it was fine to allow the > function in those properties too. > > Best, > > Alex > > On Thursday, October 10, 2024 at 1:21:47 PM UTC-7 Rune Lillesveen wrote: > > Contact emailsfuth...@chromium.org > > ExplainerNone > > > An explainer would have been helpful here for me to understand what this > is and why it makes sense. > Thankfully Vlad explained it to me offline, so I don't want to block on > this. For future intents, please add a few lines explaining what is the > thing you're trying to ship. That gives API owners (and other folks reading > through intents) the context needed to make shipping decisions. > > > > Specificationhttps://drafts.csswg.org/css-anchor-position-1/#anchor- > size-fn > > Summary > > Allow anchor-size() values for inset and margin properties. Originally, > anchor-size() was only allowed in sizing properties. The specification was > changed to allow anchor-size() in insets and margins as well. > > > Blink componentBlink>CSS > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> > > TAG reviewNone > > TAG review statusNot applicable > > Risks > > > Interoperability and Compatibility > > None > > > *Gecko*: No signal > > *WebKit*: No signal > > *Web developers*: No signals > > *Other signals*: > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > None > > > Debuggability > > None > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)?Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?Yes (wpt.fyi results not up-to-date yet) > > https://wpt.fyi/css/css-anchor-position/anchor-size-parse-valid.html > https://wpt.fyi/css/css-anchor-position/anchor-size-001.html > > > Flag name on chrome://flagsNone > > Finch feature nameCSSAnchorSizeInsetsMargins > > Requires code in //chrome?False > > Tracking bughttps://crbug.com/346521300 > > Estimated milestonesShipping on desktop132DevTrial on desktop131Shipping > on Android132DevTrial on Android131Shipping on WebView132 > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None > > Link to entry on the Chrome Platform Statushttps://chromestatus.com/ > feature/5203950077476864?gate=5101603221405696 > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > > -- > Rune Lillesveen > > > > -- > Rune Lillesveen > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit https://groups.google.com/a/ > chromium.org/d/msgid/blink-dev/CACuPfeR%3DMGEQHV% > 3Dz4bdmwQPA7VaHu2nMGYDc7skU3QjR32QtwQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeR%3DMGEQHV%3Dz4bdmwQPA7VaHu2nMGYDc7skU3QjR32QtwQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8e52a11b-097b-4f57-856b-afdfed72ba2cn%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8e52a11b-097b-4f57-856b-afdfed72ba2cn%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_Y-9EMWzL2jTGbruhoiajpXwnZzGKf7a3emTZ1QBcJhw%40mail.gmail.com.
