LGTM3 On Wed, Oct 23, 2024 at 11:27 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote:
> LGTM2 > > On Wednesday, October 23, 2024 at 8:26:40 AM UTC-7 Alex Russell wrote: > >> LGTM1 >> >> On Sunday, October 20, 2024 at 6:29:32 PM UTC-7 Kent Tamura wrote: >> >>> Contact emailstk...@chromium.org >>> >>> ExplainerNone. >>> I think an MDN page is enough. >>> https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode#sideways-rl >>> https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode#sideways-lr >>> >>> Specification >>> https://drafts.csswg.org/css-writing-modes/#propdef-writing-mode >>> >>> Summary >>> >>> Support of `sideways-rl` and `sideways-lr` keywords for `writing-mode` >>> CSS property is added. They are vertical writing modes, and all letters are >>> sideways. >>> >>> >>> Blink componentBlink>Layout>WritingMode >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ELayout%3EWritingMode> >>> >>> Search tagswriting-mode >>> <https://chromestatus.com/features#tags:writing-mode>, sideways >>> <https://chromestatus.com/features#tags:sideways> >>> >>> TAG reviewNone. Firefox already shipped this. >>> >>> TAG review statusNot applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Risks are very low. The other two engines already support or develop >>> this feature. >>> >>> >>> *Gecko*: Shipped/Shipping >>> >>> *WebKit*: In development Behind a flag >>> >>> *Web developers*: Strongly positive ( >>> https://issues.chromium.org/issues/40501131) The issue has 23 votes. >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Very low. >>> >>> This feature is an addition of new keywords to `writing-mode` property, >>> and won't change any existing behavior. >>> >>> >>> Debuggability >>> >>> Existing DevTools features should be enough. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)?Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> https://wpt.fyi/results/css/css-writing-modes >>> >>> >>> Flag name on chrome://flagsNone >>> >>> Finch feature nameSidewaysWritingModes >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://issues.chromium.org/issues/40501131 >>> >>> Non-OSS dependenciesNone. >>> >>> Estimated milestones >>> Shipping on desktop 132 >>> DevTrial on desktop 129 >>> Shipping on Android 132 >>> DevTrial on Android 129 >>> Shipping on WebView 132 >>> >>> Anticipated spec changes >>> >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/6201053052928000?gate=5108414983438336 >>> >>> Links to previous Intent discussionsIntent to Prototype: >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqFO1%3DUt7OpUvfgnyD5Gaoy7j8zFhSQRw08MDw34SfOL3g%40mail.gmail.com >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> TAMURA Kent >>> Software Engineer, Google >>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ddd493a3-70f5-4a6a-a2c0-962a3ff227a9n%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ddd493a3-70f5-4a6a-a2c0-962a3ff227a9n%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2Opku-iboOBgc9hBihRGMtV4HkjPiF39K_j_OOZw1KzYw%40mail.gmail.com.
