LGTM2

On Tue, Oct 22, 2024 at 7:03 AM Alex Russell <slightly...@chromium.org>
wrote:

> LGTM1
>
> On Mon, Oct 21, 2024, 6:16 AM Peter Beverloo <pe...@chromium.org> wrote:
>
>> Contact emailspe...@chromium.org
>>
>> Explainerhttps://github.com/w3c/push-api/pull/370
>>
>> Specificationhttps://www.w3.org/TR/push-api/#dom-pushmessagedata-bytes
>>
>> Summary
>>
>> The PushMessageData interface mimics the Body interface, which was
>> amended earlier this year with a new bytes() method, following the
>> principle that APIs should generally vend byte buffers as Uint8Arrays.
>>
>> https://github.com/w3c/push-api/pull/370
>> https://github.com/whatwg/fetch/pull/1753
>>
>> Blink componentBlink>PushAPI
>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPushAPI>
>>
>> Search tagspush <https://chromestatus.com/features#tags:push>,
>> notifications <https://chromestatus.com/features#tags:notifications>
>>
>> TAG reviewN/A, matches a W3C Design Principle that was reviewed by the
>> TAG.
>>
>> TAG review statusNot applicable
>>
>> Risks
>>
>>
>> Interoperability and Compatibility
>>
>> None
>>
>>
>> *Gecko*: Shipped/Shipping (
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1897871)
>>
>> *WebKit*: Shipped/Shipping (
>> https://bugs.webkit.org/show_bug.cgi?id=274119)
>>
>> *Web developers*: Positive (
>> https://github.com/w3ctag/design-principles/pull/480) Following a W3C
>> Design Principle
>>
>> *Other signals*:
>>
>> WebView application risks
>>
>> Does this intent deprecate or change behavior of existing APIs, such that
>> it has potentially high risk for Android WebView-based applications?
>>
>> None
>>
>>
>> Debuggability
>>
>> None
>>
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, ChromeOS, Android, and Android WebView)?All but Android WebView,
>> where the Push API is not available
>>
>> Is this feature fully tested by web-platform-tests
>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
>> ?Yes
>>
>> Flag name on chrome://flagsNone
>>
>> Finch feature nameNone
>>
>> Non-finch justification
>>
>> Minor addition to an existing, well adopted API.
>>
>>
>> Requires code in //chrome?False
>>
>> Tracking bughttps://b.corp.google.com/issues/373336950
>>
>> Estimated milestones
>> Shipping on desktop 132
>> Shipping on Android 132
>>
>> Anticipated spec changes
>>
>> Open questions about a feature may be a source of future web compat or
>> interop issues. Please list open issues (e.g. links to known github issues
>> in the project for the feature specification) whose resolution may
>> introduce web compat/interop risk (e.g., changing to naming or structure of
>> the API in a non-backward-compatible way).
>> None
>>
>> Link to entry on the Chrome Platform Status
>> https://chromestatus.com/feature/5117729756151808?gate=6280465584226304
>>
>> This intent message was generated by Chrome Platform Status
>> <https://chromestatus.com/>.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALt3x6k40_DaAWzb3gTZDyOuz_oyHazfkresF0OwixdfSDOCiw%40mail.gmail.com
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALt3x6k40_DaAWzb3gTZDyOuz_oyHazfkresF0OwixdfSDOCiw%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQj_dgDEUUBU23f9vxuxP7z%3D_cVf4CipGkfgcCBt3%2BQZ%3DQ%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQj_dgDEUUBU23f9vxuxP7z%3D_cVf4CipGkfgcCBt3%2BQZ%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra9DLK7tj%3DwQNJxzm%2B%3DqSCKxsVObNJ0Gdr4edY_3VOdaEQ%40mail.gmail.com.

Reply via email to