I've filed for a TAG review here: https://github.com/w3ctag/design-reviews/issues/1005 for completeness.
On Thu, 17 Oct 2024, at 8:44 AM, Jeffrey Yasskin wrote: > It very nearly falls into the first exception at > https://www.chromium.org/blink/guidelines/api-owners/process-exceptions/ > since it's shipping in Firefox nightly, and > https://github.com/whatwg/html/pull/10091 looks close to merging. > > On Wed, Oct 16, 2024 at 11:53 PM Keith Cirkel <chrom...@keithcirkel.co.uk> > wrote: >> __ >> It seemed unnecessary given these are the same events that popovers and >> details elements use, just applied to dialogs. I’m happy to submit it to >> TAG for review if you think otherwise. >> >> On Thu, 17 Oct 2024, at 5:09 AM, Alex Russell wrote: >>> Why was TAG Review skipped? >>> >>> On Wednesday, October 16, 2024 at 10:31:30 PM UTC+5:30 Keith Cirkel wrote: >>>> __ >>>> Thanks for catching those Joey, all fixed! >>>> >>>> On Wed, 16 Oct 2024, at 5:35 PM, Joey Arhar wrote: >>>>> Thanks Keith, this looks great! I am supportive. >>>>> >>>>> Here's the spec PR: https://github.com/whatwg/html/pull/10091 >>>>> >>>>> I anticipate the shipping milestone would be M132 if we get approval >>>>> here. Want to update the chromestatus entry? >>>>> >>>>> The RuntimeEnabledFeature flag name is DialogElementToggleEvents. >>>>> >>>>> > Will this feature be supported on all six Blink platforms (Windows, >>>>> > Mac, Linux, ChromeOS, Android, and Android WebView)? >>>>> > No >>>>> >>>>> This will be supported on all blink platforms. Want to update the >>>>> chromestatus entry? >>>>> >>>>> On Wed, Oct 16, 2024 at 9:30 AM Chromestatus >>>>> <ad...@cr-status.appspotmail.com> wrote: >>>>>> Contact emails >>>>>> >>>>>> keitha...@github.com, chrom...@keithcirkel.co.uk >>>>>> >>>>>> Explainer >>>>>> >>>>>> None >>>>>> >>>>>> Specification >>>>>> >>>>>> https://github.com/whatwg/html/issues/9733 >>>>>> >>>>>> Summary >>>>>> >>>>>> It is useful for web authors do determine when their <dialog> elements >>>>>> open and close. popover already has `ToggleEvent` which is dispatched >>>>>> when a popover opens or closes, but <dialog> does not. The current way >>>>>> to detect when a <dialog> opens is to register a mutation observer to >>>>>> check for open, however, this is quite a lot of work where an event >>>>>> would be easier. This change incorporates the same `ToggleEvent`s that >>>>>> popovers dispatch, but for `<dialog>` elements: when `showModal` or >>>>>> `show` is called, <dialog> dispatches a ToggleEvent with newState=open. >>>>>> When a dialog is closed (via form or button or closewatcher) it should >>>>>> dispatch a ToggleEvent with newState=closed. >>>>>> >>>>>> >>>>>> >>>>>> Blink component >>>>>> >>>>>> Blink>DOM >>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> >>>>>> >>>>>> TAG review >>>>>> >>>>>> None >>>>>> >>>>>> TAG review status >>>>>> >>>>>> Not applicable >>>>>> >>>>>> Risks >>>>>> >>>>>> >>>>>> >>>>>> Interoperability and Compatibility >>>>>> >>>>>> None >>>>>> >>>>>> >>>>>> >>>>>> *Gecko*: Shipped/Shipping >>>>>> (https://github.com/mozilla/standards-positions/issues/1101) >>>>>> >>>>>> *WebKit*: No signal >>>>>> >>>>>> *Web developers*: No signals >>>>>> (https://github.com/WebKit/standards-positions/issues/418) >>>>>> >>>>>> *Other signals*: >>>>>> >>>>>> WebView application risks >>>>>> >>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>> that it has potentially high risk for Android WebView-based applications? >>>>>> >>>>>> None >>>>>> >>>>>> >>>>>> >>>>>> Debuggability >>>>>> >>>>>> None >>>>>> >>>>>> >>>>>> >>>>>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>>>>> Linux, ChromeOS, Android, and Android WebView)? >>>>>> >>>>>> No >>>>>> >>>>>> Is this feature fully tested by web-platform-tests >>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? >>>>>> >>>>>> Yes >>>>>> >>>>>> Flag name on chrome://flags >>>>>> >>>>>> None >>>>>> >>>>>> Finch feature name >>>>>> >>>>>> None >>>>>> >>>>>> Non-finch justification >>>>>> >>>>>> None >>>>>> >>>>>> Requires code in //chrome? >>>>>> >>>>>> False >>>>>> >>>>>> Tracking bug >>>>>> >>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1521813 >>>>>> >>>>>> Estimated milestones >>>>>> >>>>>> No milestones specified >>>>>> >>>>>> >>>>>> >>>>>> Anticipated spec changes >>>>>> >>>>>> Open questions about a feature may be a source of future web compat or >>>>>> interop issues. Please list open issues (e.g. links to known github >>>>>> issues in the project for the feature specification) whose resolution >>>>>> may introduce web compat/interop risk (e.g., changing to naming or >>>>>> structure of the API in a non-backward-compatible way). >>>>>> >>>>>> None >>>>>> >>>>>> Link to entry on the Chrome Platform Status >>>>>> >>>>>> https://chromestatus.com/feature/5078613609938944?gate=5166222923268096 >>>>>> >>>>>> This intent message was generated by Chrome Platform Status >>>>>> <https://chromestatus.com>. >>>>>> >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/670fea20.2b0a0220.137ef7.0d39.GAE%40google.com >>>>>> >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/670fea20.2b0a0220.137ef7.0d39.GAE%40google.com?utm_medium=email&utm_source=footer>. >>>> >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9a827257-6867-4f4a-8415-9df415973aec%40app.fastmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9a827257-6867-4f4a-8415-9df415973aec%40app.fastmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/13719578-cb4c-49ad-b8b1-47e14f843f52%40app.fastmail.com.
