LGTM2 On Wed, Sep 25, 2024 at 8:45 AM Alex Russell <slightly...@chromium.org> wrote:
> LGTM1 > > On Thursday, September 19, 2024 at 12:10:56 AM UTC-7 fbea...@google.com > wrote: > >> Contact emailsfbeauf...@google.com >> >> Explainerhttps://github.com/WICG/webhid/pull/121 >> >> Specification >> https://wicg.github.io/webhid/#extensions-to-the-workernavigator-interface >> >> Summary >> >> WebHID is enabled inside dedicated worker contexts. This allows >> developers to perform heavy I/O and processing of data from a HID device on >> a separate thread to reduce the performance impact on the main thread. >> >> Blink componentBlink>HID >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHID> >> >> TAG reviewThis small addition to the WebHID API doesn’t seem to qualify >> for a TAG review. I’m happy to file one if desired though. >> >> TAG review statusNot applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> This small addition does not change the overall status of WebHID >> interoperability or compatibility. >> >> *Gecko*: No signal - Both Gecko and WebKit are unlikely to object to >> this feature specifically, but object to the overall WebHID API as a whole, >> hence it doesn't make sense to bug them with specific questions on this. >> >> *WebKit*: No signal - Both Gecko and WebKit are unlikely to object to >> this feature specifically, but object to the overall WebHID API as a whole, >> hence it doesn't make sense to bug them with specific questions on this. >> >> *Web developers*: Positive (https://github.com/WICG/webhid/issues/120) >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> None >> >> >> Debuggability >> >> No specific DevTools changes are required. This feature is treated like >> any other JS method. Note that exposing DevTools debugging support for >> device-access APIs (WebHID included) is discussed at >> https://bugs.chromium.org/p/chromium/issues/detail?id=1142566. >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)?No >> >> Android is not supported because Android itself does not provide a direct >> API for accessing HID devices. For the same reason this API is not >> available in Android WebView. >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?No >> >> WPT are planned, we have some web_tests already but the external web >> platform tests are minimal and only verify the presence of interfaces and >> attributes: https://wpt.fyi/results/webhid We have internal web tests >> that will be converted to WPT: >> https://source.chromium.org/chromium/chromium/src/+/master:third_ and >> may differ by party/blink/web_tests/hid/ >> >> Flag name on chrome://flagsenable-experimental-web-platform-features >> >> Finch feature nameWebHIDOnDedicatedWorkers >> >> Requires code in //chrome?False >> >> Tracking bug >> https://chromium-review.googlesource.com/c/chromium/src/+/5841991 >> >> Sample linkshttps://webhid-worker.glitch.me >> >> Estimated milestones >> Shipping on desktop 131 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5077348995825664?gate=5078851361964032 >> >> Links to previous Intent discussionsIntent to Prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5K9tsJ_qRhY0qV%3Dc8HzC7Q_xfN8jGZJ05iLtm67Uu7HQQ%40mail.gmail.com >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3a489c9e-ff27-48f4-9153-2337778ca32cn%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3a489c9e-ff27-48f4-9153-2337778ca32cn%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_6zn7Ser3SFmv7TDyyCjvG5V_X7gstKE_32JkzUHL-yw%40mail.gmail.com.
