LGTM3 On Wed, Aug 28, 2024 at 3:25 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote:
> LGTM2 > > On Tue, Aug 27, 2024 at 6:32 PM Vladimir Levin <vmp...@chromium.org> > wrote: > >> This looks like a fairly minor improvement to the API. It seems like the >> change would allow more contributions without increasing performance >> concerns. Please let me know if there are any subtleties that I may have >> missed. >> >> LGTM1 >> >> Thanks, >> Vlad >> >> On Fri, Aug 16, 2024 at 5:50 PM Alex Turner <ale...@chromium.org> wrote: >> >>> Contact emailsale...@chromium.org >>> >>> Explainer >>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/135 >>> >>> Specification >>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/136 >>> >>> Summary >>> >>> Modifies the Private Aggregation API to merge histogram contributions >>> with the same bucket and filtering ID before embedding in the aggregatable >>> report's encrypted payload. Private Aggregation imposes a limit on the >>> number of contributions that can be embedded in a single aggregatable >>> report, with any additional contributions being dropped. By merging >>> together contributions where possible, we can get additional utility out of >>> the limit. Note that, ignoring the dropping of excess contributions, >>> merging these sorts of contributions should not have any impact on the >>> final outputs (i.e. summary reports). >>> >>> >>> Blink componentBlink>PrivateAggregation >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPrivateAggregation> >>> >>> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/846 (We have >>> not requested a signal for these changes specifically.) >>> >>> TAG review statusPending >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> None >>> >>> >>> *Gecko*: No signal ( >>> https://github.com/mozilla/standards-positions/issues/805) We have not >>> requested a signal for this change specifically. The Gecko position on >>> Shared Storage (one of the ways Private Aggregation is exposed) is negative. >>> >>> *WebKit*: No signal ( >>> https://github.com/WebKit/standards-positions/issues/189) We have not >>> requested a signal for this change specifically. >>> >>> *Web developers*: Positive ( >>> https://github.com/patcg-individual-drafts/private-aggregation-api/issues/81 >>> ) >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> No new debug capabilities beyond the existing internals page >>> (chrome://private-aggregation-internals) and temporary debug mode. These >>> capabilities will reflect the merged contributions. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? >>> >>> All but WebView >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> Flag name on chrome://flagsNone >>> >>> Finch feature namePrivateAggregationApiContributionMerging >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://crbug.com/349980058 >>> >>> Launch bughttps://launch.corp.google.com/launch/4333118 >>> >>> Estimated milestones >>> Shipping on desktop 129 >>> Shipping on Android 129 >>> >>> Anticipated spec changes >>> >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5094168719523840?gate=5075771428438016 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiFk8hn%3DnCSBg8pf7naZGqHgd8-DpOv7v0q4YokycSMG7xA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiFk8hn%3DnCSBg8pf7naZGqHgd8-DpOv7v0q4YokycSMG7xA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2PTcqDG6uQ7HZS8ofCbMxgOw%3DrdQZ7Bj3xERYQStJS%3Dsw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2PTcqDG6uQ7HZS8ofCbMxgOw%3DrdQZ7Bj3xERYQStJS%3Dsw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKmYCKwmAKfKVy7oAL%3D0M-USA78Dvr2nRyXiRxS2Ua2vQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKmYCKwmAKfKVy7oAL%3D0M-USA78Dvr2nRyXiRxS2Ua2vQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8EmKNbUrcDDsVo9wUK8aww45CwVyK58haUseduNZO2tw%40mail.gmail.com.
